Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor async notifiers implementation #717

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Refactor async notifiers implementation #717

merged 3 commits into from
Dec 12, 2024

Conversation

asvetlov
Copy link
Member

The PR doesn't affect existing functionality but simplifies the code.

Copy link

codspeed-hq bot commented Dec 12, 2024

CodSpeed Performance Report

Merging #717 will not alter performance

Comparing refactor (c11d809) with master (a85cc40)

Summary

✅ 4 untouched benchmarks

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.55%. Comparing base (a85cc40) to head (c11d809).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #717      +/-   ##
==========================================
+ Coverage   94.18%   94.55%   +0.37%     
==========================================
  Files           5        5              
  Lines        1495     1470      -25     
  Branches      135      129       -6     
==========================================
- Hits         1408     1390      -18     
+ Misses         54       53       -1     
+ Partials       33       27       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@x42005e1f
Copy link
Contributor

There is if self._loop is not None on line 128. Maybe it should be deleted?

@asvetlov
Copy link
Member Author

There is if self._loop is not None on line 128. Maybe it should be deleted?

Done

@asvetlov asvetlov merged commit 57ac3fc into master Dec 12, 2024
13 checks passed
@asvetlov asvetlov deleted the refactor branch December 12, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants