-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sync notifiers for a major speedup #714
Conversation
|
CodSpeed Performance ReportMerging #714 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #714 +/- ##
==========================================
- Coverage 94.54% 94.49% -0.06%
==========================================
Files 5 5
Lines 1504 1490 -14
Branches 131 131
==========================================
- Hits 1422 1408 -14
Misses 53 53
Partials 29 29 ☔ View full report in Codecov by Sentry. |
It looks like benchmarks are hardware dependent. In the CodSpeed profiler, I do not see notifiers for the |
codspeed does the best. It normalizes the speed to mitigate different performance of test boxes, and it also removes syscalls times. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good finding, thanks!
Avoids creating new threads since the mutex is already held in the queue methods.