Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation #713

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Update documentation #713

merged 1 commit into from
Dec 10, 2024

Conversation

x42005e1f
Copy link
Contributor

What do these changes do?

This PR updates the documentation to reflect the latest changes: recommends to use the new aclose() method (ad2b1bd) and clarifies that the slowdown "can be", but not necessarily "will be" (4a57895). In fact, in no-wait tests Janus can now be comparable to standard queues, but in worst cases where notification methods are often called, it can still show significant performance slowdown, so "only when used as intended" remains. In particular, in Culsans benchmarks Janus is still slower than the naive solution.

Are there changes in behavior for the user?

There are no behavior changes for users.

Copy link

codspeed-hq bot commented Dec 10, 2024

CodSpeed Performance Report

Merging #713 will not alter performance

Comparing x42005e1f:master (ef166f1) with master (4a57895)

Summary

✅ 4 untouched benchmarks

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.42%. Comparing base (4a57895) to head (ef166f1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #713   +/-   ##
=======================================
  Coverage   94.42%   94.42%           
=======================================
  Files           5        5           
  Lines        1472     1472           
  Branches      127      127           
=======================================
  Hits         1390     1390           
  Misses         55       55           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asvetlov asvetlov merged commit b1e6e0f into aio-libs:master Dec 10, 2024
13 checks passed
@asvetlov
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants