Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR updates the documentation to reflect the latest changes: recommends to use the new
aclose()
method (ad2b1bd) and clarifies that the slowdown "can be", but not necessarily "will be" (4a57895). In fact, in no-wait tests Janus can now be comparable to standard queues, but in worst cases where notification methods are often called, it can still show significant performance slowdown, so "only when used as intended" remains. In particular, in Culsans benchmarks Janus is still slower than the naive solution.Are there changes in behavior for the user?
There are no behavior changes for users.