Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating janus.Queue without running asyncio loop #710

Merged
merged 13 commits into from
Dec 10, 2024
Merged

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Dec 6, 2024

Closes #448

Copy link

codspeed-hq bot commented Dec 6, 2024

CodSpeed Performance Report

Merging #710 will not alter performance

Comparing no-loop (c38e30e) with master (b1e6e0f)

Summary

✅ 4 untouched benchmarks

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 97.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.54%. Comparing base (b1e6e0f) to head (c38e30e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
janus/__init__.py 96.49% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #710      +/-   ##
==========================================
+ Coverage   94.42%   94.54%   +0.11%     
==========================================
  Files           5        5              
  Lines        1472     1504      +32     
  Branches      127      131       +4     
==========================================
+ Hits         1390     1422      +32     
+ Misses         55       53       -2     
- Partials       27       29       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asvetlov asvetlov merged commit e180116 into master Dec 10, 2024
13 checks passed
@asvetlov asvetlov deleted the no-loop branch December 10, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No running event loop
1 participant