Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tonybaloney verify 312 #456

Merged
merged 4 commits into from
Oct 28, 2023
Merged

Tonybaloney verify 312 #456

merged 4 commits into from
Oct 28, 2023

Conversation

jettify
Copy link
Member

@jettify jettify commented Oct 28, 2023

What do these changes do?

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Merging #456 (238faa2) into master (53fe8a6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #456   +/-   ##
=======================================
  Coverage   87.01%   87.01%           
=======================================
  Files           6        6           
  Lines         493      493           
  Branches       73       73           
=======================================
  Hits          429      429           
  Misses         48       48           
  Partials       16       16           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jettify jettify merged commit 732a67d into master Oct 28, 2023
7 checks passed
@jettify jettify deleted the tonybaloney-verify_312 branch October 28, 2023 20:08
@jettify jettify mentioned this pull request Oct 28, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants