-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update type annotations in connection.py #429
base: master
Are you sure you want to change the base?
Conversation
Changes looks good but
you can run
to repro. |
The specific annotations were copied from pool.py.
9e671b6
to
7e3789f
Compare
Codecov Report
@@ Coverage Diff @@
## master #429 +/- ##
==========================================
+ Coverage 86.93% 87.02% +0.08%
==========================================
Files 6 6
Lines 490 501 +11
Branches 73 73
==========================================
+ Hits 426 436 +10
- Misses 48 49 +1
Partials 16 16
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I rebased the branch with the recent changes. Note the changes in aa8d847; the commit contains the changes associated with the use of |
What do these changes do?
asyncio.Future
-returning methods to native coroutines, updating the return types in the process1Are there changes in behavior for the user?
Users should now have consistent type hinting when interacting the public API.
Related issue number
#275
#421
Checklist
CHANGES
folder<issue_id>.<type>
(e.g.588.bugfix
)issue_id
change it to the pr id after creating the PR.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.
Footnotes
https://github.com/aio-libs/aioodbc/pull/429#discussion_r1183201672 ↩
https://peps.python.org/pep-0563/ ↩