Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Pool.closed property as present in aiopg, fixes #463 #726

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

Nothing4You
Copy link
Collaborator

What do these changes do?

New closed property for Pool instances, exposing whether the pool is closed.

Are there changes in behavior for the user?

New property available.

Related issue number

Fixes #463

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment to CHANGES.txt

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #726 (e6c0aa9) into master (00d0932) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #726   +/-   ##
=======================================
  Coverage   92.71%   92.71%           
=======================================
  Files          35       35           
  Lines        5448     5452    +4     
  Branches      918      919    +1     
=======================================
+ Hits         5051     5055    +4     
  Misses        309      309           
  Partials       88       88           
Flag Coverage Δ
ubuntu-latest_3.10_mariadb-10.2 89.49% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.10_mariadb-10.3 89.49% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.10_mariadb-10.4 89.49% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.10_mariadb-10.5 89.47% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.10_mariadb-10.6 89.47% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.10_mariadb-10.7 89.47% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.10_mysql-5.7 90.18% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.10_mysql-8.0 91.59% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.11-dev_mariadb-10.2 89.45% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.11-dev_mariadb-10.3 89.45% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.11-dev_mariadb-10.4 89.45% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.11-dev_mariadb-10.5 89.43% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.11-dev_mariadb-10.6 89.43% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.11-dev_mariadb-10.7 89.43% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.11-dev_mysql-5.7 90.15% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.11-dev_mysql-8.0 91.56% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.7_mariadb-10.2 88.89% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.7_mariadb-10.3 88.89% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.7_mariadb-10.4 88.89% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.7_mariadb-10.5 88.87% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.7_mariadb-10.6 88.87% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.7_mariadb-10.7 88.87% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.7_mysql-5.7 89.63% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.7_mysql-8.0 91.13% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.8_mariadb-10.2 89.53% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.8_mariadb-10.3 89.53% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.8_mariadb-10.4 89.53% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.8_mariadb-10.5 89.51% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.8_mariadb-10.6 89.51% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.8_mariadb-10.7 89.51% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.8_mysql-5.7 90.22% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.8_mysql-8.0 91.62% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.9_mariadb-10.2 89.40% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.9_mariadb-10.3 89.40% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.9_mariadb-10.4 89.40% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.9_mariadb-10.5 89.38% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.9_mariadb-10.6 89.38% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.9_mariadb-10.7 89.38% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.9_mysql-5.7 90.10% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.9_mysql-8.0 91.49% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiomysql/pool.py 97.04% <100.00%> (+0.05%) ⬆️
tests/test_pool.py 97.38% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00d0932...e6c0aa9. Read the comment docs.

@Nothing4You Nothing4You merged commit 30b9ea5 into master Feb 2, 2022
@Nothing4You Nothing4You deleted the add-pool-closed branch February 2, 2022 22:35
@Nothing4You Nothing4You added this to the 1.0 milestone Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pool lose closed property
1 participant