Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add python 3.11 tests #722

Merged
merged 1 commit into from
Jan 31, 2022
Merged

add python 3.11 tests #722

merged 1 commit into from
Jan 31, 2022

Conversation

Nothing4You
Copy link
Collaborator

What do these changes do?

add python 3.11 tests.
uvloop is disabled on python 3.11 for now due to cython incompatibility.
a new cython version has since been released but uvloop needs to be built against this new cython version.
see MagicStack/uvloop#450 and MagicStack/uvloop#459

Are there changes in behavior for the user?

no

@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #722 (c64ca30) into master (c9e349d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #722    +/-   ##
========================================
  Coverage   92.69%   92.69%            
========================================
  Files          35       35            
  Lines        5432     5436     +4     
  Branches      586      914   +328     
========================================
+ Hits         5035     5039     +4     
  Misses        309      309            
  Partials       88       88            
Flag Coverage Δ
ubuntu-latest_3.10_mariadb-10.2 89.45% <60.00%> (-0.03%) ⬇️
ubuntu-latest_3.10_mariadb-10.3 89.45% <60.00%> (-0.03%) ⬇️
ubuntu-latest_3.10_mariadb-10.4 89.45% <60.00%> (-0.03%) ⬇️
ubuntu-latest_3.10_mariadb-10.5 89.44% <60.00%> (-0.03%) ⬇️
ubuntu-latest_3.10_mariadb-10.6 89.44% <60.00%> (-0.03%) ⬇️
ubuntu-latest_3.10_mariadb-10.7 89.44% <60.00%> (-0.03%) ⬇️
ubuntu-latest_3.10_mysql-5.7 90.15% <60.00%> (-0.03%) ⬇️
ubuntu-latest_3.10_mysql-8.0 91.57% <60.00%> (-0.04%) ⬇️
ubuntu-latest_3.11-dev_mariadb-10.2 89.42% <60.00%> (?)
ubuntu-latest_3.11-dev_mariadb-10.3 89.42% <60.00%> (?)
ubuntu-latest_3.11-dev_mariadb-10.4 89.42% <60.00%> (?)
ubuntu-latest_3.11-dev_mariadb-10.5 89.40% <60.00%> (?)
ubuntu-latest_3.11-dev_mariadb-10.6 89.40% <60.00%> (?)
ubuntu-latest_3.11-dev_mariadb-10.7 89.40% <60.00%> (?)
ubuntu-latest_3.11-dev_mysql-5.7 90.12% <60.00%> (?)
ubuntu-latest_3.11-dev_mysql-8.0 91.53% <60.00%> (?)
ubuntu-latest_3.7_mariadb-10.2 88.86% <60.00%> (-0.04%) ⬇️
ubuntu-latest_3.7_mariadb-10.3 88.86% <60.00%> (-0.04%) ⬇️
ubuntu-latest_3.7_mariadb-10.4 88.86% <60.00%> (-0.04%) ⬇️
ubuntu-latest_3.7_mariadb-10.5 88.84% <60.00%> (-0.04%) ⬇️
ubuntu-latest_3.7_mariadb-10.6 88.84% <60.00%> (-0.04%) ⬇️
ubuntu-latest_3.7_mariadb-10.7 88.84% <60.00%> (-0.04%) ⬇️
ubuntu-latest_3.7_mysql-5.7 89.61% <60.00%> (-0.04%) ⬇️
ubuntu-latest_3.7_mysql-8.0 91.11% <60.00%> (-0.04%) ⬇️
ubuntu-latest_3.8_mariadb-10.2 89.50% <60.00%> (-0.03%) ⬇️
ubuntu-latest_3.8_mariadb-10.3 89.50% <60.00%> (-0.03%) ⬇️
ubuntu-latest_3.8_mariadb-10.4 89.50% <60.00%> (-0.03%) ⬇️
ubuntu-latest_3.8_mariadb-10.5 89.48% <60.00%> (-0.03%) ⬇️
ubuntu-latest_3.8_mariadb-10.6 89.48% <60.00%> (-0.03%) ⬇️
ubuntu-latest_3.8_mariadb-10.7 89.48% <60.00%> (-0.03%) ⬇️
ubuntu-latest_3.8_mysql-5.7 90.20% <60.00%> (-0.03%) ⬇️
ubuntu-latest_3.8_mysql-8.0 91.60% <60.00%> (-0.04%) ⬇️
ubuntu-latest_3.9_mariadb-10.2 89.37% <60.00%> (-0.03%) ⬇️
ubuntu-latest_3.9_mariadb-10.3 89.37% <60.00%> (-0.03%) ⬇️
ubuntu-latest_3.9_mariadb-10.4 89.37% <60.00%> (-0.03%) ⬇️
ubuntu-latest_3.9_mariadb-10.5 89.35% <60.00%> (-0.03%) ⬇️
ubuntu-latest_3.9_mariadb-10.6 89.35% <60.00%> (-0.03%) ⬇️
ubuntu-latest_3.9_mariadb-10.7 89.35% <60.00%> (-0.03%) ⬇️
ubuntu-latest_3.9_mysql-5.7 90.07% <60.00%> (-0.03%) ⬇️
ubuntu-latest_3.9_mysql-8.0 91.47% <60.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/conftest.py 87.19% <100.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9e349d...c64ca30. Read the comment docs.

uvloop is disabled on python 3.11 for now due to cython incompatibility.
a new cython version has since been released but uvloop needs to be built against this new cython version.
see MagicStack/uvloop#450 and MagicStack/uvloop#459
@Nothing4You
Copy link
Collaborator Author

tests on py3.11 randomly fail: https://github.com/aio-libs/aiomysql/runs/5000103904?check_suite_focus=true#step:12:11

re-running the tests will succeed.

I haven't had time to try to repro this locally yet to see if I can figure out a consistently reproducible case.

@Nothing4You Nothing4You merged commit c0972d2 into master Jan 31, 2022
@Nothing4You Nothing4You deleted the py3.11-tests branch January 31, 2022 01:34
@Nothing4You
Copy link
Collaborator Author

after some extensive testing I was finally able to determine the root cause of these failures to be in coverage.py: nedbat/coveragepy#1316

Nothing4You added a commit that referenced this pull request Jan 31, 2022
This reverts commit c0972d2.

coverage.py still has issues with Python 3.11, there's not much point in keeping them if they segfault half the time.
nedbat/coveragepy#1316
Nothing4You added a commit that referenced this pull request Feb 1, 2022
This reverts commit c0972d2.

coverage.py still has issues with Python 3.11, there's not much point in keeping them if they segfault half the time.
nedbat/coveragepy#1316
Nothing4You added a commit that referenced this pull request Feb 2, 2022
uvloop is disabled on python 3.11 for now due to cython incompatibility.
a new cython version has since been released but uvloop needs to be built against this new cython version.
see MagicStack/uvloop#450 and MagicStack/uvloop#459
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant