Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev/build dependencies to work better with Python 3.12 #405

Merged
merged 3 commits into from
Apr 13, 2024

Conversation

achimnol
Copy link
Member

@achimnol achimnol commented Apr 13, 2024

What do these changes do?

This PR updates dev/build dependencies in requirements-dev.txt and pyproject.toml to work better with Python 3.12.
Though, it does NOT change the minimum requirements of runtime dependencies in setup.cfg.

For example, setuptools needs to be later than v66.2 as it fixes use of pkgutil.ImpImporter deprecated in Python 3.12.
(reference: pypa/pip#11501 (comment))

pre-commit in requirements-dev.txt is pinned to v3.5.0 as it dropped the support for Python 3.8 since v3.6.0.

Are there changes in behavior for the user?

There should be no functional changes in the user side.

Checklist

  • I think the code is well written

@achimnol achimnol added the dependencies Pull requests that update a dependency file label Apr 13, 2024
@achimnol achimnol self-assigned this Apr 13, 2024
@achimnol achimnol enabled auto-merge April 13, 2024 09:15
@achimnol achimnol added this pull request to the merge queue Apr 13, 2024
Merged via the queue into main with commit aaba8dc Apr 13, 2024
12 checks passed
@achimnol achimnol deleted the deps/upgrade-dev-dependencies branch April 13, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant