Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9972/9916d329 backport][3.11] Revert "Only construct the allowed_methods set once for a StaticResource" #9973

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Nov 19, 2024

This is a backport of PR #9972 as merged into master (9916d32).

Reverts #9911

aiohttp-cors accesses the protected self._routes here and relies on being able to add new methods
https://github.com/aio-libs/aiohttp-cors/blob/38c6c17bffc805e46baccd7be1b4fd8c69d95dc3/aiohttp_cors/urldispatcher_router_adapter.py#L187

Copy link

codspeed-hq bot commented Nov 19, 2024

CodSpeed Performance Report

Merging #9973 will not alter performance

Comparing patchback/backports/3.11/9916d3298e84ea8fe8e5600b4b858b2829d21155/pr-9972 (44e2611) with 3.11 (902e7b2)

Summary

✅ 43 untouched benchmarks

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (3.11@85ef646). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.11    #9973   +/-   ##
=======================================
  Coverage        ?   98.02%           
=======================================
  Files           ?      122           
  Lines           ?    36866           
  Branches        ?     4438           
=======================================
  Hits            ?    36137           
  Misses          ?      545           
  Partials        ?      184           
Flag Coverage Δ
CI-GHA 97.91% <100.00%> (?)
OS-Linux 97.61% <100.00%> (?)
OS-Windows 94.51% <100.00%> (?)
OS-macOS 96.73% <100.00%> (?)
Py-3.10.11 96.58% <100.00%> (?)
Py-3.10.15 97.12% <100.00%> (?)
Py-3.11.10 97.19% <100.00%> (?)
Py-3.11.9 96.66% <100.00%> (?)
Py-3.12.7 97.68% <100.00%> (?)
Py-3.13.0 97.67% <100.00%> (?)
Py-3.9.13 96.51% <100.00%> (?)
Py-3.9.20 97.09% <100.00%> (?)
Py-pypy7.3.16 96.65% <100.00%> (?)
VM-macos 96.73% <100.00%> (?)
VM-ubuntu 97.61% <100.00%> (?)
VM-windows 94.51% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco enabled auto-merge (squash) November 19, 2024 04:52
@bdraco bdraco merged commit 39f6832 into 3.11 Nov 19, 2024
35 of 36 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/9916d3298e84ea8fe8e5600b4b858b2829d21155/pr-9972 branch November 19, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant