Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9939/509fddfd backport][3.10] Fix test_resolve_gitapi_subapps benchmark #9948

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Nov 17, 2024

This is a backport of PR #9939 as merged into master (509fddf).

Also add checks that url dispatcher benchmarks find expected routes

Also add checks that url dispatcher benchmarks find expected routes

(cherry picked from commit 509fddf)
Copy link

codspeed-hq bot commented Nov 17, 2024

CodSpeed Performance Report

Merging #9948 will degrade performances by 82.53%

Comparing patchback/backports/3.10/509fddfd3c6673bfa5ad11783e8d49e57d5a2fbe/pr-9939 (73d8af0) with 3.10 (43ee43b)

Summary

❌ 1 (👁 1) regressions
✅ 41 untouched benchmarks

Benchmarks breakdown

Benchmark 3.10 patchback/backports/3.10/509fddfd3c6673bfa5ad11783e8d49e57d5a2fbe/pr-9939 Change
👁 test_resolve_gitapi_subapps[pyloop] 56.6 ms 324.1 ms -82.53%

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.94%. Comparing base (43ee43b) to head (73d8af0).
Report is 1 commits behind head on 3.10.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.10    #9948   +/-   ##
=======================================
  Coverage   97.93%   97.94%           
=======================================
  Files         116      116           
  Lines       36146    36207   +61     
  Branches     4381     4383    +2     
=======================================
+ Hits        35401    35462   +61     
  Misses        553      553           
  Partials      192      192           
Flag Coverage Δ
CI-GHA 97.83% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.53% <100.00%> (-0.01%) ⬇️
OS-Windows 95.17% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.24% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.09% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.08% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 97.11% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.18% <100.00%> (+0.02%) ⬆️
Py-3.12.7 97.60% <100.00%> (+0.04%) ⬆️
Py-3.13.0 97.59% <100.00%> (+0.01%) ⬆️
Py-3.8.10 94.57% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.88% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.01% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 97.00% <100.00%> (+0.04%) ⬆️
Py-pypy7.3.16 96.56% <100.00%> (+<0.01%) ⬆️
VM-macos 97.24% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.53% <100.00%> (-0.01%) ⬇️
VM-windows 95.17% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asvetlov asvetlov merged commit 7d120a5 into 3.10 Nov 17, 2024
39 of 40 checks passed
@asvetlov asvetlov deleted the patchback/backports/3.10/509fddfd3c6673bfa5ad11783e8d49e57d5a2fbe/pr-9939 branch November 17, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants