[PR #9935/0c312496 backport][3.10] Add benchmark for routing sub_applications #9936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
Router should be optimized for handling 2 kind of prefix resources
(sub_apps and static files are handled equally now):
1. sub_apps are placed under non-overlapped top-level single-segment
prefixed. `test_resolve_gitapi_subapps` benchmark test this case
already.
2. sub_apps shares the same prefix segments, e.g.
`/api/manager/plugin/{name}`.
This PR covers the second case.
(cherry picked from commit 0c31249)
CodSpeed Performance ReportMerging #9936 will not alter performanceComparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## 3.10 #9936 +/- ##
=======================================
Coverage 97.93% 97.93%
=======================================
Files 115 115
Lines 36095 36113 +18
Branches 4366 4371 +5
=======================================
+ Hits 35350 35368 +18
Misses 553 553
Partials 192 192
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
asvetlov
deleted the
patchback/backports/3.10/0c312496c6490f934cec360f21ae802e2c8d8679/pr-9935
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #9935 as merged into master (0c31249).
Router should be optimized for handling 2 kind of prefix resources (sub_apps and static files are handled equally now):
test_resolve_gitapi_subappsbenchmark test this case already./api/manager/plugin/{name}.This PR covers the second case.