Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9929/73691e49 backport][3.10] Add couple benchmarks for dynamic routes #9930

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Nov 16, 2024

This is a backport of PR #9929 as merged into master (73691e4).

It helps tuning UrlDispatcher performance

It helps tuning UrlDispatcher performance

(cherry picked from commit 73691e4)
Copy link

codspeed-hq bot commented Nov 16, 2024

CodSpeed Performance Report

Merging #9930 will not alter performance

Comparing patchback/backports/3.10/73691e4907bfeecf80d87f647bacc98282d2f70a/pr-9929 (08021c5) with 3.10 (1866a49)

Summary

✅ 33 untouched benchmarks

🆕 3 new benchmarks
⁉️ 1 (👁 1) dropped benchmarks

Benchmarks breakdown

Benchmark 3.10 patchback/backports/3.10/73691e4907bfeecf80d87f647bacc98282d2f70a/pr-9929 Change
🆕 test_resolve_dynamic_resource_url_with_many_dynamic_routes[pyloop] N/A 4.2 ms N/A
🆕 test_resolve_dynamic_resource_url_with_many_dynamic_routes_with_common_prefix[pyloop] N/A 264 ms N/A
👁 test_resolve_dynamic_resource_url_with_many_routes[pyloop] 4.4 ms N/A N/A
🆕 test_resolve_dynamic_resource_url_with_many_static_routes[pyloop] N/A 4.2 ms N/A

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.93%. Comparing base (1866a49) to head (08021c5).
Report is 1 commits behind head on 3.10.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.10    #9930   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files         115      115           
  Lines       36065    36095   +30     
  Branches     4358     4366    +8     
=======================================
+ Hits        35320    35350   +30     
  Misses        553      553           
  Partials      192      192           
Flag Coverage Δ
CI-GHA 97.83% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.53% <100.00%> (+<0.01%) ⬆️
OS-Windows 95.15% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.24% <100.00%> (+0.01%) ⬆️
Py-3.10.11 97.09% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.03% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 97.10% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.17% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 97.60% <100.00%> (+0.01%) ⬆️
Py-3.13.0 97.58% <100.00%> (-0.01%) ⬇️
Py-3.8.10 94.55% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.83% <100.00%> (-0.05%) ⬇️
Py-3.9.13 97.00% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 96.95% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 96.54% <100.00%> (-0.01%) ⬇️
VM-macos 97.24% <100.00%> (+0.01%) ⬆️
VM-ubuntu 97.53% <100.00%> (+<0.01%) ⬆️
VM-windows 95.15% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 58a78f6 into 3.10 Nov 17, 2024
39 of 40 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/73691e4907bfeecf80d87f647bacc98282d2f70a/pr-9929 branch November 17, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants