-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmarks for github url resolving emulation #9925
Conversation
CodSpeed Performance ReportMerging #9925 will improve performances by 8.07%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9925 +/- ##
=======================================
Coverage 98.71% 98.71%
=======================================
Files 120 120
Lines 36479 36540 +61
Branches 4342 4353 +11
=======================================
+ Hits 36011 36072 +61
Misses 315 315
Partials 153 153
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
That websocket test flaps a bit because of memory allocation inconsistency. We might want to add it to the ignores until it can be tuned a bit more. Or simply ignore it for now since it's still a semi rare flap. Ideally we would reduce the memcpy there instead but I don't have a good strategy for doing that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a good idea to me.
I'm ok to do nothing with it until a champion fixes the flappines (or implementation). |
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #9926 🤖 @patchback |
I think github API is a representative example for possible route table. (cherry picked from commit 69756b4)
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #9927 🤖 @patchback |
I think github API is a representative example for possible route table. (cherry picked from commit 69756b4)
Backport to 3.12: 💚 backport PR created✅ Backport PR branch: Backported as #9928 🤖 @patchback |
I think github API is a representative example for possible route table. (cherry picked from commit 69756b4)
…lving emulation (#9927) **This is a backport of PR #9925 as merged into master (69756b4).** I think github API is a representative example for possible route table. Co-authored-by: Andrew Svetlov <[email protected]>
…lving emulation (#9928) **This is a backport of PR #9925 as merged into master (69756b4).** I think github API is a representative example for possible route table. Co-authored-by: Andrew Svetlov <[email protected]>
…lving emulation (#9926) **This is a backport of PR #9925 as merged into master (69756b4).** I think github API is a representative example for possible route table. Co-authored-by: Andrew Svetlov <[email protected]>
I think github API is a representative example for possible route table.