Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks for github url resolving emulation #9925

Merged
merged 2 commits into from
Nov 16, 2024
Merged

Conversation

asvetlov
Copy link
Member

I think github API is a representative example for possible route table.

@asvetlov asvetlov added bot:chronographer:skip This PR does not need to include a change note backport-3.10 backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels Nov 16, 2024
Copy link

codspeed-hq bot commented Nov 16, 2024

CodSpeed Performance Report

Merging #9925 will improve performances by 8.07%

Comparing github-benchmarks (7649f01) with master (e9637a9)

Summary

⚡ 1 improvements
✅ 31 untouched benchmarks

🆕 2 new benchmarks

Benchmarks breakdown

Benchmark master github-benchmarks Change
test_one_thousand_large_round_trip_websocket_text_messages[pyloop] 25.3 ms 23.4 ms +8.07%
🆕 test_resolve_gitapi[pyloop] N/A 315.3 ms N/A
🆕 test_resolve_gitapi_subapps[pyloop] N/A 8.6 ms N/A

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (e9637a9) to head (7649f01).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9925   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files         120      120           
  Lines       36479    36540   +61     
  Branches     4342     4353   +11     
=======================================
+ Hits        36011    36072   +61     
  Misses        315      315           
  Partials      153      153           
Flag Coverage Δ
CI-GHA 98.60% <100.00%> (+<0.01%) ⬆️
OS-Linux 98.29% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.11% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.38% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.23% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.78% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 97.83% <100.00%> (+0.01%) ⬆️
Py-3.11.9 97.29% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 98.36% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 98.35% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.15% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 97.74% <100.00%> (+0.04%) ⬆️
Py-pypy7.3.16 97.31% <100.00%> (+<0.01%) ⬆️
VM-macos 97.38% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 98.29% <100.00%> (+<0.01%) ⬆️
VM-windows 96.11% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco
Copy link
Member

bdraco commented Nov 16, 2024

That websocket test flaps a bit because of memory allocation inconsistency. We might want to add it to the ignores until it can be tuned a bit more. Or simply ignore it for now since it's still a semi rare flap.

Ideally we would reduce the memcpy there instead but I don't have a good strategy for doing that

Copy link
Member

@Dreamsorcerer Dreamsorcerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea to me.

@asvetlov
Copy link
Member Author

That websocket test flaps a bit because of memory allocation inconsistency. We might want to add it to the ignores until it can be tuned a bit more. Or simply ignore it for now since it's still a semi rare flap.

I'm ok to do nothing with it until a champion fixes the flappines (or implementation).

@asvetlov asvetlov merged commit 69756b4 into master Nov 16, 2024
43 of 45 checks passed
@asvetlov asvetlov deleted the github-benchmarks branch November 16, 2024 14:35
Copy link
Contributor

patchback bot commented Nov 16, 2024

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/69756b495d8fe0e1bf47056582d63cb6b0cb2913/pr-9925

Backported as #9926

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 16, 2024
I think github API is a representative example for possible route table.

(cherry picked from commit 69756b4)
Copy link
Contributor

patchback bot commented Nov 16, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/69756b495d8fe0e1bf47056582d63cb6b0cb2913/pr-9925

Backported as #9927

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 16, 2024
I think github API is a representative example for possible route table.

(cherry picked from commit 69756b4)
Copy link
Contributor

patchback bot commented Nov 16, 2024

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/69756b495d8fe0e1bf47056582d63cb6b0cb2913/pr-9925

Backported as #9928

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 16, 2024
I think github API is a representative example for possible route table.

(cherry picked from commit 69756b4)
asvetlov added a commit that referenced this pull request Nov 16, 2024
…lving emulation (#9927)

**This is a backport of PR #9925 as merged into master
(69756b4).**

I think github API is a representative example for possible route table.

Co-authored-by: Andrew Svetlov <[email protected]>
asvetlov added a commit that referenced this pull request Nov 16, 2024
…lving emulation (#9928)

**This is a backport of PR #9925 as merged into master
(69756b4).**

I think github API is a representative example for possible route table.

Co-authored-by: Andrew Svetlov <[email protected]>
asvetlov added a commit that referenced this pull request Nov 16, 2024
…lving emulation (#9926)

**This is a backport of PR #9925 as merged into master
(69756b4).**

I think github API is a representative example for possible route table.

Co-authored-by: Andrew Svetlov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants