Issue997 default connector limit #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default was changed from `None` to 20. `None` used to mean that there were no limits at all, so all number of connections were allowed to the same endpoint. Not, when the user does not specify, the default is 20, but it is still possible to set `None`. #977
In the docs, document the new behaviour of the `limit` parameter, which now defaults to 20, instead of `None`.
|
Thank you very much! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Changes the default limit for connections from None, to 20
Are there changes in behavior for the user?
It should not, unless the user was expecting to always use an unlimited number of connections all the time, in which case, they are now being bounded to 20.
Related issue number
Issue#997
Checklist