Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9883/a118114 backport][3.11] Fix improperly closed WebSocket connections generating a backtrace #9884

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 14, 2024

(cherry picked from commit a118114)

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 14, 2024
@bdraco bdraco changed the title Fix improperly closed WebSocket connections generating a backtrace (#9883) [PR #9883/a118114 backport][3.11] Fix improperly closed WebSocket connections generating a backtrace Nov 14, 2024
Copy link

codspeed-hq bot commented Nov 14, 2024

CodSpeed Performance Report

Merging #9884 will not alter performance

Comparing patchback/backports/3.11/a11811471ded1a4df59302316d12fc90a3cfc819/pr-9883 (0e187c8) with 3.11 (e998143)

Summary

✅ 24 untouched benchmarks

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.99%. Comparing base (e998143) to head (0e187c8).
Report is 1 commits behind head on 3.11.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.11    #9884      +/-   ##
==========================================
+ Coverage   97.82%   97.99%   +0.17%     
==========================================
  Files         119      119              
  Lines       36392    36435      +43     
  Branches     4353     4364      +11     
==========================================
+ Hits        35599    35706     +107     
+ Misses        588      545      -43     
+ Partials      205      184      -21     
Flag Coverage Δ
CI-GHA 97.88% <100.00%> (+0.15%) ⬆️
OS-Linux 97.58% <100.00%> (+0.19%) ⬆️
OS-Windows 94.44% <97.43%> (+0.43%) ⬆️
OS-macOS 96.69% <97.43%> (+0.08%) ⬆️
Py-3.10.11 96.54% <97.43%> (-0.01%) ⬇️
Py-3.10.15 97.14% <100.00%> (+0.04%) ⬆️
Py-3.11.10 97.16% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 96.61% <97.43%> (+0.28%) ⬆️
Py-3.12.7 97.65% <100.00%> (+1.18%) ⬆️
Py-3.13.0 97.65% <100.00%> (+1.17%) ⬆️
Py-3.9.13 96.47% <97.43%> (?)
Py-3.9.20 97.06% <100.00%> (?)
Py-pypy7.3.16 96.61% <100.00%> (?)
VM-macos 96.69% <97.43%> (+0.08%) ⬆️
VM-ubuntu 97.58% <100.00%> (+0.19%) ⬆️
VM-windows 94.44% <97.43%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco enabled auto-merge (squash) November 14, 2024 20:48
@bdraco bdraco merged commit 581390c into 3.11 Nov 14, 2024
33 of 34 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/a11811471ded1a4df59302316d12fc90a3cfc819/pr-9883 branch November 14, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant