Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in enable_cleanup_closed warning message #9736

Merged
merged 2 commits into from
Nov 9, 2024
Merged

Fix typo in enable_cleanup_closed warning message #9736

merged 2 commits into from
Nov 9, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 9, 2024

The message had in twice

@bdraco bdraco added backport-3.10 backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Nov 9, 2024
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 9, 2024
@bdraco bdraco changed the title Fix typo in enable_cleanup_closed warning Fix typo in enable_cleanup_closed warning message Nov 9, 2024
@bdraco bdraco marked this pull request as ready for review November 9, 2024 14:24
@bdraco bdraco enabled auto-merge (squash) November 9, 2024 14:24
Copy link

codspeed-hq bot commented Nov 9, 2024

CodSpeed Performance Report

Merging #9736 will not alter performance

Comparing typo_fix (02d4bbb) with master (c3a9c3e)

Summary

✅ 14 untouched benchmarks

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.67%. Comparing base (c3a9c3e) to head (02d4bbb).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9736      +/-   ##
==========================================
+ Coverage   98.60%   98.67%   +0.06%     
==========================================
  Files         117      117              
  Lines       35807    35807              
  Branches     4250     4250              
==========================================
+ Hits        35307    35331      +24     
+ Misses        340      320      -20     
+ Partials      160      156       -4     
Flag Coverage Δ
CI-GHA 98.55% <ø> (+0.05%) ⬆️
OS-Linux 98.24% <ø> (+0.05%) ⬆️
OS-Windows 95.99% <ø> (ø)
OS-macOS 97.30% <ø> (-0.01%) ⬇️
Py-3.10.11 97.15% <ø> (ø)
Py-3.10.15 97.72% <ø> (ø)
Py-3.11.10 97.77% <ø> (ø)
Py-3.11.9 97.22% <ø> (ø)
Py-3.12.7 98.26% <ø> (ø)
Py-3.13.0 98.24% <ø> (ø)
Py-3.9.13 97.07% <ø> (ø)
Py-3.9.20 97.63% <ø> (ø)
Py-pypy7.3.16 97.25% <ø> (?)
VM-macos 97.30% <ø> (-0.01%) ⬇️
VM-ubuntu 98.24% <ø> (+0.05%) ⬆️
VM-windows 95.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 5ddeb06 into master Nov 9, 2024
37 of 38 checks passed
@bdraco bdraco deleted the typo_fix branch November 9, 2024 14:52
Copy link
Contributor

patchback bot commented Nov 9, 2024

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/5ddeb06f98b135c5c7169e605d09574ebab4a8e7/pr-9736

Backported as #9739

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link
Contributor

patchback bot commented Nov 9, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/5ddeb06f98b135c5c7169e605d09574ebab4a8e7/pr-9736

Backported as #9740

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 9, 2024
bdraco pushed a commit that referenced this pull request Nov 9, 2024
bdraco added a commit that referenced this pull request Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant