Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9692/e85db24 backport][3.11] Change RequestInfo to be a NamedTuple to improve performances #9708

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 7, 2024

(cherry picked from commit e85db24)

aiohttp 3.11.0b1 yarl 1.17.1 (no change from b1/b2)
aiohttp 3 11 0b1+change yarl 1 17 1

this change
aiohttp_3_11_0b4_yarl_1_17_1

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 7, 2024
@bdraco bdraco changed the title Change RequestInfo to be a NamedTuple to improve performances (#9692) [PR #9692/e85db24 backport][3.11] Change RequestInfo to be a NamedTuple to improve performances Nov 7, 2024
@bdraco bdraco marked this pull request as ready for review November 7, 2024 19:29
@bdraco bdraco enabled auto-merge (squash) November 7, 2024 19:29
Copy link

codspeed-hq bot commented Nov 7, 2024

CodSpeed Performance Report

Merging #9708 will not alter performance

Comparing patchback/backports/3.11/e85db24d78c01598395ee0d1c16d19bce54118ba/pr-9692 (835f190) with 3.11 (ea1c084)

Summary

✅ 14 untouched benchmarks

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.92%. Comparing base (ea1c084) to head (835f190).
Report is 2 commits behind head on 3.11.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.11    #9708      +/-   ##
==========================================
- Coverage   97.92%   97.92%   -0.01%     
==========================================
  Files         117      117              
  Lines       35844    35840       -4     
  Branches     4294     4292       -2     
==========================================
- Hits        35101    35097       -4     
  Misses        557      557              
  Partials      186      186              
Flag Coverage Δ
CI-GHA 97.81% <100.00%> (-0.01%) ⬇️
OS-Linux 97.50% <100.00%> (-0.01%) ⬇️
OS-Windows 94.42% <100.00%> (-0.01%) ⬇️
OS-macOS 96.72% <100.00%> (-0.01%) ⬇️
Py-3.10.11 96.57% <100.00%> (+0.29%) ⬆️
Py-3.10.15 97.00% <100.00%> (+0.56%) ⬆️
Py-3.11.10 97.06% <100.00%> (-0.01%) ⬇️
Py-3.11.9 96.65% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 97.54% <100.00%> (-0.01%) ⬇️
Py-3.13.0 97.52% <100.00%> (-0.01%) ⬇️
Py-3.9.13 96.50% <100.00%> (-0.01%) ⬇️
Py-3.9.20 96.93% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 96.54% <100.00%> (+<0.01%) ⬆️
VM-macos 96.72% <100.00%> (-0.01%) ⬇️
VM-ubuntu 97.50% <100.00%> (-0.01%) ⬇️
VM-windows 94.42% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco disabled auto-merge November 7, 2024 20:14
@bdraco bdraco enabled auto-merge (squash) November 7, 2024 20:18
@bdraco bdraco merged commit 76f7722 into 3.11 Nov 7, 2024
33 of 34 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/e85db24d78c01598395ee0d1c16d19bce54118ba/pr-9692 branch November 7, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant