Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9671/37d9fe6 backport][3.11] Refactor connection waiters to be cancellation safe #9675

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 5, 2024

(cherry picked from commit 37d9fe6)

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 5, 2024
Copy link

codspeed-hq bot commented Nov 5, 2024

CodSpeed Performance Report

Merging #9675 will not alter performance

Comparing patchback/backports/3.11/37d9fe68387e3672604ff5b183f48538bca34f16/pr-9671 (392f170) with 3.11 (262fb12)

Summary

✅ 13 untouched benchmarks

@bdraco bdraco changed the title Refactor connection waiters to be cancellation safe (#9671) [PR #9671/37d9fe6 backport][3.11] Refactor connection waiters to be cancellation safe Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.90%. Comparing base (262fb12) to head (392f170).
Report is 2 commits behind head on 3.11.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##             3.11    #9675    +/-   ##
========================================
  Coverage   97.89%   97.90%            
========================================
  Files         117      117            
  Lines       35559    35673   +114     
  Branches     4264     4277    +13     
========================================
+ Hits        34811    34926   +115     
  Misses        559      559            
+ Partials      189      188     -1     
Flag Coverage Δ
CI-GHA 97.79% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.48% <100.00%> (+0.01%) ⬆️
OS-Windows 94.40% <100.00%> (+0.02%) ⬆️
OS-macOS 96.69% <100.00%> (+0.01%) ⬆️
Py-3.10.11 96.55% <99.63%> (+0.01%) ⬆️
Py-3.10.15 96.98% <99.63%> (+0.01%) ⬆️
Py-3.11.10 97.05% <100.00%> (+0.01%) ⬆️
Py-3.11.9 96.64% <100.00%> (+0.02%) ⬆️
Py-3.12.7 97.52% <100.00%> (+0.01%) ⬆️
Py-3.13.0 97.51% <100.00%> (+0.01%) ⬆️
Py-3.9.13 96.47% <100.00%> (+0.01%) ⬆️
Py-3.9.20 96.90% <100.00%> (+0.01%) ⬆️
Py-pypy7.3.16 96.51% <100.00%> (+0.01%) ⬆️
VM-macos 96.69% <100.00%> (+0.01%) ⬆️
VM-ubuntu 97.48% <100.00%> (+0.01%) ⬆️
VM-windows 94.40% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco
Copy link
Member Author

bdraco commented Nov 5, 2024

Ran the reproducer against this and its confirmed fixed

@bdraco bdraco marked this pull request as ready for review November 5, 2024 16:50
@bdraco
Copy link
Member Author

bdraco commented Nov 5, 2024

Looks like the PR volume overloaded RTD.

Will close reopen to get another run

@bdraco bdraco closed this Nov 5, 2024
@bdraco bdraco reopened this Nov 5, 2024
@bdraco bdraco enabled auto-merge (squash) November 5, 2024 17:20
@bdraco bdraco merged commit 37ef0fb into 3.11 Nov 5, 2024
64 of 66 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/37d9fe68387e3672604ff5b183f48538bca34f16/pr-9671 branch November 5, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant