[PR #9367/b612127d backport][3.11] Speed up handling auth in urls #9381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
(cherry picked from commit b612127)
bdraco
added
the
bot:chronographer:skip
bdraco
approved these changes
Oct 1, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## 3.11 #9381 +/- ##
=======================================
Coverage 97.80% 97.80%
=======================================
Files 108 108
Lines 35051 35053 +2
Branches 4185 4185
=======================================
+ Hits 34280 34282 +2
Misses 574 574
Partials 197 197
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bdraco
deleted the
patchback/backports/3.11/b612127d4ef5d99bd47151d8643e590f12cd5c20/pr-9367
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #9367 as merged into master (b612127).
What do these changes do?
Avoids calling the .user and .password methods if the raw versions are not set as auth in urls is going to be the rare case.
The cache of
raw_passwordandraw_useris guaranteed to be set in yarl once the netloc is parsedAre there changes in behavior for the user?
no
Is it a substantial burden for the maintainers to support this?
no
before
after
