correct variable name in testing docs #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| TestClient can also be used as a contextmanager, returning | ||
| the instance of itself instantiated. | ||
| """ | ||
|
|
||
| def __init__(self, app, protocol="http"): | ||
| self._app = app | ||
| self.app = app |
There was a problem hiding this comment.
Why did you covert app to public name?
There was a problem hiding this comment.
Yes, was about to make a comment about this.
Very often in tests it's helpful to get access to the app eg. to get the db connection and check data has changed as expected.
There was a problem hiding this comment.
Since aiohttp encourages app holding all variables this is basically the test client's only way of getting access to serverside data.
|
thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Correct variable name in pytest section of testing docs
Checklist