-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Generic for TestClient.app #8977
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #8977 +/- ##
=======================================
Coverage 98.42% 98.42%
=======================================
Files 107 107
Lines 34681 34707 +26
Branches 4110 4114 +4
=======================================
+ Hits 34134 34160 +26
Misses 380 380
Partials 167 167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 6db2c74 on top of patchback/backports/3.11/6db2c747572b3e77a2d64e3f6c5a01ecae74fcff/pr-8977 Backporting merged PR #8977 into master
🤖 @patchback |
There are a lot of conflicts in the backport as I wasn't 100% sure on all of them. |
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: J. Nick Koston <[email protected]> (cherry picked from commit 6db2c74)
Co-authored-by: J. Nick Koston <[email protected]> (cherry picked from commit 6db2c74)
This should avoid annoying
assert client.app is not None
lines in test code.Fixes #7226.