Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a gunicorn worker that uses uvloop #878

Merged
merged 1 commit into from
May 17, 2016

Conversation

1st1
Copy link
Contributor

@1st1 1st1 commented May 17, 2016

What does this change do?

This PR provides a gunicorn worker that runs uvloop. This is something that has to be done at the worker level, since when the app is actually running, it's already too late to set up the uvloop policy.

How to test your changes?

I've updated test/test_worker.py to test the new worker too. Alternatively, you can run a hello world application using the new worker with

$ gunicorn test:app --worker-class aiohttp.worker.GunicornUVLoopWebWorker --workers 2 --bind localhost:8080

Related issue number

There is no aiohttp issue regarding this, but there is one in the uvloop project: MagicStack/uvloop#26

Checklist

  • Code is written and well
  • Tests for the changes are provided
  • Documentation reflects the changes

@1st1 1st1 force-pushed the uvloop-gunicorn branch 2 times, most recently from 66acd9e to 06c7363 Compare May 17, 2016 02:11
@1st1 1st1 force-pushed the uvloop-gunicorn branch from 06c7363 to 95c31ac Compare May 17, 2016 02:18
@coveralls
Copy link

coveralls commented May 17, 2016

Coverage Status

Coverage increased (+0.002%) to 98.22% when pulling 95c31ac on 1st1:uvloop-gunicorn into 889b7f1 on KeepSafe:master.

@fafhrd91 fafhrd91 merged commit 7a77fff into aio-libs:master May 17, 2016
@fafhrd91
Copy link
Member

Thanks

@1st1
Copy link
Contributor Author

1st1 commented May 17, 2016

Thanks, Nikolay. When are you going to issue a new release?

@fafhrd91
Copy link
Member

Usually @asvetlov makes releases. Let me ask him if he has time

@1st1
Copy link
Contributor Author

1st1 commented Jul 7, 2016

@fafhrd91 @asvetlov Guys, is it possible to issue a new aiohttp release? What's the ETA? The last release was on May 5th...

@fafhrd91
Copy link
Member

@asvetlov do you want us to handle new releases of aiohttp?

@asvetlov
Copy link
Member

Will do it in a few days.
I want to fix a couple of issues first.

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants