-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a gunicorn worker that uses uvloop #878
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1st1
force-pushed
the
uvloop-gunicorn
branch
2 times, most recently
from
May 17, 2016 02:11
66acd9e
to
06c7363
Compare
Thanks |
Thanks, Nikolay. When are you going to issue a new release? |
Usually @asvetlov makes releases. Let me ask him if he has time |
5 tasks
@asvetlov do you want us to handle new releases of aiohttp? |
Will do it in a few days. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change do?
This PR provides a gunicorn worker that runs uvloop. This is something that has to be done at the worker level, since when the app is actually running, it's already too late to set up the uvloop policy.
How to test your changes?
I've updated
test/test_worker.py
to test the new worker too. Alternatively, you can run a hello world application using the new worker with$ gunicorn test:app --worker-class aiohttp.worker.GunicornUVLoopWebWorker --workers 2 --bind localhost:8080
Related issue number
There is no aiohttp issue regarding this, but there is one in the uvloop project: MagicStack/uvloop#26
Checklist