Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cleanup_ctx example for sharing resources across subapps #8694

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Add cleanup_ctx example for sharing resources across subapps #8694

merged 2 commits into from
Aug 14, 2024

Conversation

Dreamsorcerer
Copy link
Member

Fixes #3876.

@Dreamsorcerer Dreamsorcerer added backport-3.10 backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Aug 13, 2024
@Dreamsorcerer Dreamsorcerer added the bot:chronographer:skip This PR does not need to include a change note label Aug 13, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.96%. Comparing base (4f41d05) to head (2ba2985).
Report is 839 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8694   +/-   ##
=======================================
  Coverage   97.96%   97.96%           
=======================================
  Files         107      107           
  Lines       33860    33860           
  Branches     3970     3970           
=======================================
  Hits        33170    33170           
  Misses        513      513           
  Partials      177      177
Flag Coverage Δ
CI-GHA 97.86% <ø> (ø)
OS-Linux 97.52% <ø> (ø)
OS-Windows 95.90% <ø> (ø)
OS-macOS 97.19% <ø> (ø)
Py-3.10.11 95.72% <ø> (-1.61%) ⬇️
Py-3.10.14 97.16% <ø> (-0.11%) ⬇️
Py-3.11.9 97.49% <ø> (ø)
Py-3.12.4 97.61% <ø> (ø)
Py-3.8.10 95.54% <ø> (ø)
Py-3.8.18 97.05% <ø> (ø)
Py-3.9.13 97.20% <ø> (ø)
Py-3.9.19 97.14% <ø> (ø)
Py-pypy7.3.16 96.73% <ø> (ø)
VM-macos 97.19% <ø> (ø)
VM-ubuntu 97.52% <ø> (ø)
VM-windows 95.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco
Copy link
Member

bdraco commented Aug 14, 2024

Screenshot 2024-08-13 at 8 47 49 PM

@Dreamsorcerer Dreamsorcerer merged commit d83804d into master Aug 14, 2024
37 of 38 checks passed
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-4 branch August 14, 2024 12:08
@patchback Patchback
Copy link
Contributor

patchback bot commented Aug 14, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/d83804db6a77221c996dfa3710ba6cf6b58d08b9/pr-8694

Backported as #8695

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 14, 2024
@Dreamsorcerer @patchback
Add cleanup_ctx example for sharing resources across subapps (#8694)
58256a2 
(cherry picked from commit d83804d)
@patchback patchback bot mentioned this pull request Aug 14, 2024
Merged
@patchback Patchback
Copy link
Contributor

patchback bot commented Aug 14, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/d83804db6a77221c996dfa3710ba6cf6b58d08b9/pr-8694

Backported as #8696

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 14, 2024
@Dreamsorcerer @patchback
Add cleanup_ctx example for sharing resources across subapps (#8694)
59f87ed 
(cherry picked from commit d83804d)
@patchback patchback bot mentioned this pull request Aug 14, 2024
Merged
Dreamsorcerer added a commit that referenced this pull request Aug 14, 2024
@patchback @Dreamsorcerer
[PR #8694/d83804db backport][3.11] Add cleanup_ctx example for sharin…
fb18325 
…g resources across subapps (#8696)

**This is a backport of PR #8694 as merged into master
(d83804d).**

Co-authored-by: Sam Bull <[email protected]>
Dreamsorcerer added a commit that referenced this pull request Aug 14, 2024
@patchback @Dreamsorcerer
[PR #8694/d83804db backport][3.10] Add cleanup_ctx example for sharin…
7d593ec 
…g resources across subapps (#8695)

**This is a backport of PR #8694 as merged into master
(d83804d).**

Co-authored-by: Sam Bull <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdraco bdraco bdraco approved these changes

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sharing cleanup_ctx data with sub-apps
2 participants
@Dreamsorcerer @bdraco