Fix handling of unsupported upgrades with the pure python http parser #8252
Conversation
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8252 +/- ##
=======================================
Coverage 97.53% 97.53%
=======================================
Files 107 107
Lines 32843 32845 +2
Branches 3851 3851
=======================================
+ Hits 32032 32034 +2
Misses 610 610
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
#7960 passed but I guess I need to scape more out of there. Had to leave for the airport, so will have to pick it up later. |
|
I assume this affected all platforms then. Linux being fast enough that the race condition succeeded, Windows being slow enough that it always failed, and Mac being unreliable enough that it passes half the time? |
Co-authored-by: Sam Bull <[email protected]>
Yes that is the same conclusion I reached as well. |
Backport to 3.9: 💚 backport PR created✅ Backport PR branch: Backported as #8254 🤖 @patchback |
…#8252) Co-authored-by: Sam Bull <[email protected]> (cherry picked from commit 8f23712)
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #8255 🤖 @patchback |
…#8252) Co-authored-by: Sam Bull <[email protected]> (cherry picked from commit 8f23712)
…es with the pure python http parser (#8255) Co-authored-by: J. Nick Koston <[email protected]>
…s with the pure python http parser (#8254) Co-authored-by: J. Nick Koston <[email protected]>
| @@ -0,0 +1,2 @@ | |||
| Fixed content not being read when an upgrade request was not supported with the pure Python implementation. | |||
There was a problem hiding this comment.
@bdraco it's best not to put a trailing period at the end of the sentence if the byline is right after — RST will render it on the same line. If you want a separate line, add an extra empty separator line in between. Look how it's rendered now: https://docs.aiohttp.org/en/latest/changes.html#bug-fixes.
Also, I suggest not using any period after the byline if it's on a dedicated line as opposed to being at the end of a sentence.
Examples:
- https://yarl.aio-libs.org/en/latest/changes/#id5 — look at the last entry — here I have a byline at the end of the first sentence/paragraph. So the sentence itself doesn't have a period before the em dash but it ends with one right after the byline. It's followed by a separate paragraph of additional text.
- https://multidict.aio-libs.org/en/latest/changes/#id3 — most entries here have bylines on separate lines, I only missed to drop a trailing period from one, but others are nice.
due to an issue in underlying aiohttp library, http2 upgrade requests caused an internal error. This was fixed in [#8252](aio-libs/aiohttp#8252) and presumeably included in release 3.9.4, but included test shows, that is only fixed for >= 3.10.2. Co-authored-by: Andreas Schimmelschulze <[email protected]>
due to an issue in underlying aiohttp library, http2 upgrade requests caused an internal error. This was fixed in [#8252](aio-libs/aiohttp#8252) and presumeably included in release 3.9.4, but included test shows, that is only fixed for >= 3.10.2. Co-authored-by: Andreas Schimmelschulze <[email protected]>
What do these changes do?
Fix handling of unsupported upgrades with the pure python http parser
The content is now read from an unsupported upgrade request
Is it a substantial burden for the maintainers to support this?
no
Related issue number
Checklist
CONTRIBUTORS.txtCHANGES/foldername it
<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature: A new behavior, public APIs. That sort of stuff..deprecation: A declaration of future API removals and breakingchanges in behavior.
.breaking: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc: Notable updates to the documentation structure or buildprocess.
.packaging: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.