Release v3.9.4

[Dreamsorcerer]

Preparing for tomorrow, let me know if there's any reason to delay. @bdraco @webknjaz

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.39%. Comparing base (a7e240a) to head (95eca18).
Report is 1 commits behind head on 3.9.

Additional details and impacted files

@@           Coverage Diff           @@
##              3.9    #8201   +/-   ##
=======================================
  Coverage   97.39%   97.39%           
=======================================
  Files         108      108           
  Lines       32849    32849           
  Branches     3900     3900           
=======================================
  Hits        31994    31994           
  Misses        645      645           
  Partials      210      210           

Flag	Coverage Δ
CI-GHA	97.30% <100.00%> (ø)
OS-Linux	96.98% <100.00%> (ø)
OS-Windows	94.53% <ø> (ø)
OS-macOS	96.65% <100.00%> (ø)
Py-3.10.11	94.34% <ø> (-0.01%)	⬇️
Py-3.10.14	96.76% <100.00%> (-0.01%)	⬇️
Py-3.11.9	97.02% <100.00%> (ø)
Py-3.12.2	97.07% <100.00%> (ø)
Py-3.8.10	94.32% <ø> (-0.01%)	⬇️
Py-3.8.18	96.70% <100.00%> (ø)
Py-3.9.13	94.33% <ø> (-0.01%)	⬇️
Py-3.9.19	96.75% <100.00%> (ø)
Py-pypy7.3.15	96.29% <100.00%> (ø)
VM-macos	96.65% <100.00%> (ø)
VM-ubuntu	96.98% <100.00%> (ø)
VM-windows	94.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[webknjaz]

LGTM

[bdraco]

#8184 might be ready tomorrow but its not a regression and its been a problem for a while so no need to wait for it

[Dreamsorcerer]

#8184 might be ready tomorrow but its not a regression and its been a problem for a while so no need to wait for it

Probably a good one to have in, not sure if we want to do any more 3.9 releases after this. I'll do the release later in the week if you need time to finish it.

[bdraco]

I was hoping to get a thumbs up from the op on if it fixed it for his user before moving it forward. I'll write the tests for it tomorrow regardless, since I'll be time poor at the end of the week as I have family in town.

[webknjaz]

I was hoping to get a thumbs up from the op on if it fixed it for his user before moving it forward.

@bdraco did you get that info?

[Dreamsorcerer]

That one's merged now. We've had a couple of other last minute bug reports we've been fixing, but I think we're good for me to proceed with a release tomorrow.

[webknjaz]

Sounds good!