Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #758: Handle empty body with gzipped encoding #807

Merged
merged 1 commit into from
Feb 28, 2016

Conversation

asvetlov
Copy link
Member

Fix for #758

@kxepal
Copy link
Member

kxepal commented Feb 28, 2016

+1
I had the same issue workaround. But those changes were not accepted ):

@asvetlov
Copy link
Member Author

@kxepal what do you mean by not accepted?
@fafhrd91 rejected your PR to aiohttp about the change?
I cannot remember any issue for the problem, sorry.

@asvetlov
Copy link
Member Author

Got it

@asvetlov
Copy link
Member Author

See also #154

@kxepal
Copy link
Member

kxepal commented Feb 28, 2016

Reread the backlog. "not accepted" was a bad wording, sorry, didn't remember all the details. Asked for a bit more work in addition to addressing current issue - yes, but for those cases were not in my list. Ironically, now we're almost in sync (I didn't took 304 response into account) (;

Anyway, it's good that this problem finally get fixed (: \o/

@asvetlov
Copy link
Member Author

@fafhrd91 do you agree with the patch?

@fafhrd91
Copy link
Member

+1

asvetlov added a commit that referenced this pull request Feb 28, 2016
Fix #758: Handle empty body with gzipped encoding
@asvetlov asvetlov merged commit a565ee6 into master Feb 28, 2016
@asvetlov
Copy link
Member Author

Done

@asvetlov asvetlov deleted the handle_empty_body_with_gzip branch February 28, 2016 23:26
kaiw added a commit to kaiw/aiocouchdb that referenced this pull request Feb 5, 2019
This appears to have been fixed already by
aio-libs/aiohttp#807
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants