Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement filter_cookies() with domain-matching and path-matching #8046

Conversation

Dreamsorcerer
Copy link
Member

(#7944)


Co-authored-by: Sam Bull [email protected]
Co-authored-by: J. Nick Koston [email protected]
(cherry picked from commit 54ceb6f)

)

---------

Co-authored-by: Sam Bull <[email protected]>
Co-authored-by: J. Nick Koston <[email protected]>
(cherry picked from commit 54ceb6f)
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 21, 2024
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4b91b53) 97.39% compared to head (e645510) 97.39%.
Report is 1 commits behind head on 3.10.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.10    #8046      +/-   ##
==========================================
- Coverage   97.39%   97.39%   -0.01%     
==========================================
  Files         108      108              
  Lines       32813    32799      -14     
  Branches     3903     3903              
==========================================
- Hits        31958    31944      -14     
  Misses        650      650              
  Partials      205      205              
Flag Coverage Δ
CI-GHA 97.30% <100.00%> (-0.01%) ⬇️
OS-Linux 96.99% <100.00%> (-0.01%) ⬇️
OS-Windows 94.51% <100.00%> (-0.01%) ⬇️
OS-macOS 96.80% <100.00%> (-0.01%) ⬇️
Py-3.10.11 94.41% <100.00%> (-0.01%) ⬇️
Py-3.10.13 96.77% <100.00%> (-0.01%) ⬇️
Py-3.11.7 96.48% <100.00%> (-0.01%) ⬇️
Py-3.12.1 ?
Py-3.8.10 94.39% <100.00%> (-0.01%) ⬇️
Py-3.8.18 96.71% <100.00%> (-0.01%) ⬇️
Py-3.9.13 94.40% <100.00%> (-0.01%) ⬇️
Py-3.9.18 96.75% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.15 96.30% <100.00%> (+<0.01%) ⬆️
VM-macos 96.80% <100.00%> (-0.01%) ⬇️
VM-ubuntu 96.99% <100.00%> (-0.01%) ⬇️
VM-windows 94.51% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit a42ed20 into 3.10 Jan 21, 2024
27 of 31 checks passed
@Dreamsorcerer Dreamsorcerer deleted the patchback/backports/3.10/54ceb6fd48ff4c4add2107a460376fc72c2b76e9/pr-7944 branch January 21, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants