Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the Towncrier philosophy link #8010

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Fix the Towncrier philosophy link #8010

merged 1 commit into from
Jan 20, 2024

Conversation

Jamim
Copy link
Contributor

@Jamim Jamim commented Jan 8, 2024

What do these changes do?

These changes fix a broken link to towncrier's philosophy.

Are there changes in behavior for the user?

Link from CHANGES/README.rst to towncrier's philosophy will be fixed.

Related issue number

Similar PR:

Checklist

  • I think the code is well written
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder

Best regards!

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 8, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (25d96fa) 97.46% compared to head (cf97257) 97.46%.
Report is 9 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8010   +/-   ##
=======================================
  Coverage   97.46%   97.46%           
=======================================
  Files         107      107           
  Lines       32526    32526           
  Branches     3791     3791           
=======================================
  Hits        31700    31700           
  Misses        624      624           
  Partials      202      202
Flag Coverage Δ
CI-GHA 97.37% <ø> (ø)
OS-Linux 97.05% <ø> (ø)
OS-Windows 95.54% <ø> (ø)
OS-macOS 96.87% <ø> (ø)
Py-3.10.11 95.47% <ø> (ø)
Py-3.10.13 96.86% <ø> (ø)
Py-3.11.7 96.57% <ø> (ø)
Py-3.12.1 96.66% <ø> (ø)
Py-3.8.10 95.43% <ø> (ø)
Py-3.8.18 96.79% <ø> (ø)
Py-3.9.13 95.43% <ø> (ø)
Py-3.9.18 96.82% <ø> (-0.01%) ⬇️
Py-pypy7.3.13 ?
Py-pypy7.3.15 96.38% <ø> (?)
VM-macos 96.87% <ø> (ø)
VM-ubuntu 97.05% <ø> (ø)
VM-windows 95.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit 2670e7b into aio-libs:master Jan 20, 2024
31 of 34 checks passed
@patchback Patchback
Copy link
Contributor

patchback bot commented Jan 20, 2024 •
edited
Loading

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/2670e7b08da179e74a643dca8d795fd23fcd282e/pr-8010

Backported as #8039

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 20, 2024
@Jamim @patchback
Fix the Towncrier philosophy link (#8010)
f49f8a9 
(cherry picked from commit 2670e7b)
@patchback patchback bot mentioned this pull request Jan 20, 2024
Merged
3 tasks
@patchback Patchback
Copy link
Contributor

patchback bot commented Jan 20, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/2670e7b08da179e74a643dca8d795fd23fcd282e/pr-8010

Backported as #8040

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 20, 2024
@Jamim @patchback
Fix the Towncrier philosophy link (#8010)
6298767 
(cherry picked from commit 2670e7b)
@patchback patchback bot mentioned this pull request Jan 20, 2024
Merged
3 tasks
Dreamsorcerer pushed a commit that referenced this pull request Jan 20, 2024
@patchback
[PR #8010/2670e7b0 backport][3.9] Fix the Towncrier philosophy link (#…
f000174 
…8039)

**This is a backport of PR #8010 as merged into master
(2670e7b).**
Dreamsorcerer pushed a commit that referenced this pull request Jan 20, 2024
@patchback
[PR #8010/2670e7b0 backport][3.10] Fix the Towncrier philosophy link (#…
641f4ae 
…8040)

**This is a backport of PR #8010 as merged into master
(2670e7b).**
@Jamim Jamim deleted the fix/towncrier-philosophy-link branch January 20, 2024 17:19
@webknjaz
Copy link
Member

webknjaz commented Jan 30, 2024 •
edited
Loading

FTR this was backported to 3.9/3.10 but the change note wasn't included in 3.9.2 (while the fragment file was removed from those branches). Now, it shows up in the changelog draft because the fragment remains on master (and 3.10): https://github.com/aio-libs/aiohttp/pull/8082/files#r1470427111.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jamim @webknjaz @Dreamsorcerer