Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix closing connection after read (#7867) #7868

Conversation

matan1008
Copy link

What do these changes do?

This change keeps the connection open after reading the response to allow reuse of the connection

Are there changes in behavior for the user?

no

Related issue number

#7867

Checklist

Just wanted to make sure this change is welcomed before going over the checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@matan1008 matan1008 requested a review from asvetlov as a code owner November 22, 2023 16:19
@Dreamsorcerer
Copy link
Member

Dreamsorcerer commented Nov 22, 2023

This change keeps the connection open after reading the response to allow reuse of the connection

I'm pretty sure this does the opposite. You've removed the line of code which releases the connection so it can be reused.

I'm hoping your issue will be correctly resolved by #7869.

@Dreamsorcerer
Copy link
Member

Superseded by #7879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants