Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coroutine wrapper to await after exception #7785

Merged
merged 4 commits into from
Nov 3, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions aiohttp/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -1108,8 +1108,8 @@
def send(self, arg: None) -> "asyncio.Future[Any]":
return self._coro.send(arg)

def throw(self, arg: BaseException) -> None: # type: ignore[override]
self._coro.throw(arg) # type: ignore[unused-awaitable]
def throw(self, arg: BaseException) -> "asyncio.Future[Any]":
Dreamsorcerer marked this conversation as resolved.
Show resolved Hide resolved
return self._coro.throw(arg)

Check warning on line 1112 in aiohttp/client.py

View check run for this annotation

Codecov / codecov/patch

aiohttp/client.py#L1112

Added line #L1112 was not covered by tests

def close(self) -> None:
return self._coro.close()
Expand Down
Loading