-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation: complete client docs for honoring proxy env vars #7235
Update documentation: complete client docs for honoring proxy env vars #7235
Conversation
I'm not sure that's accurate, but I'd rather we linked to the documentation upstream here. |
Thanks a lot for the reply. Indeed this is more accurate. I tried to address the comment by linking to upstream in |
Co-authored-by: Sam Bull <[email protected]>
Co-authored-by: Sam Bull <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #7235 +/- ##
==========================================
- Coverage 97.31% 97.31% -0.01%
==========================================
Files 107 107
Lines 31352 31405 +53
Branches 3901 3926 +25
==========================================
+ Hits 30511 30562 +51
Misses 640 640
- Partials 201 203 +2
Flags with carried forward coverage won't be shown. Click here to find out more. see 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Backport to 3.9: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 1c49738 on top of patchback/backports/3.9/1c4973881f9f49e65720b89b194cc1d327e5bd32/pr-7235 Backporting merged PR #7235 into master
🤖 @patchback |
If you could handle the backport, as above, that would be great. |
aio-libs#7235) <!-- Thank you for your contribution! --> * Update proxy support docs to honor `no_proxy` env * Complete `trust_env` parameter description to honor `wss_proxy`, `ws_proxy` or `no_proxy` env No Update docs for: aio-libs#4431 - [ ] I think the code is well written - [ ] Unit tests for the changes exist - [x] Documentation reflects the changes - [ ] If you provide code modification, please add yourself to `CONTRIBUTORS.txt` * The format is <Name> <Surname>. * Please keep alphabetical order, the file is sorted by names. - [ ] Add a new news fragment into the `CHANGES` folder * name it `<issue_id>.<type>` for example (588.bugfix) * if you don't have an `issue_id` change it to the pr id after creating the pr * ensure type is one of the following: * `.feature`: Signifying a new feature. * `.bugfix`: Signifying a bug fix. * `.doc`: Signifying a documentation improvement. * `.removal`: Signifying a deprecation or removal of public API. * `.misc`: A ticket has been closed, but it is not of interest to users. * Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files." --------- Co-authored-by: Marcel Loop <[email protected]> Co-authored-by: Sam Bull <[email protected]> (cherry picked from commit 1c49738)
Created the backport here #7256 |
…235 (#7256) **This is a backport of the PR #7235 as merged into master ( 1c49738 ) ## What do these changes do? * Update proxy support docs to honor `no_proxy` env * Complete `trust_env` parameter description to honor `wss_proxy`, `ws_proxy` or `no_proxy` env ## Are there changes in behavior for the user? No ## Related issue number Update docs for: #4431 ## Checklist - [ ] I think the code is well written - [ ] Unit tests for the changes exist - [x] Documentation reflects the changes - [ ] If you provide code modification, please add yourself to `CONTRIBUTORS.txt` * The format is <Name> <Surname>. * Please keep alphabetical order, the file is sorted by names. - [ ] Add a new news fragment into the `CHANGES` folder * name it `<issue_id>.<type>` for example (588.bugfix) * if you don't have an `issue_id` change it to the pr id after creating the pr * ensure type is one of the following: * `.feature`: Signifying a new feature. * `.bugfix`: Signifying a bug fix. * `.doc`: Signifying a documentation improvement. * `.removal`: Signifying a deprecation or removal of public API. * `.misc`: A ticket has been closed, but it is not of interest to users. * Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."
What do these changes do?
no_proxy
envtrust_env
parameter description to honorwss_proxy
,ws_proxy
orno_proxy
envAre there changes in behavior for the user?
No
Related issue number
Update docs for: #4431
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.