Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] Fix CI (#7143) #7200

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[3.9] Fix CI (#7143)
(cherry picked from commit c919bfa)
Dreamsorcerer committed Feb 10, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 7100e743089672166bc9560cf1ee49c31920ea48
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -59,9 +59,9 @@ jobs:
- name: Run linters
run: |
make mypy
- name: Install libenchant-dev
- name: Install libenchant
run: |
sudo apt install libenchant-dev
sudo apt install libenchant-2-dev
- name: Install spell checker
run: |
pip install -r requirements/doc-spelling.txt -c requirements/constraints.txt
1 change: 1 addition & 0 deletions aiohttp/helpers.py
Original file line number Diff line number Diff line change
@@ -62,6 +62,7 @@
PY_37 = sys.version_info >= (3, 7)
PY_38 = sys.version_info >= (3, 8)
PY_310 = sys.version_info >= (3, 10)
PY_311 = sys.version_info >= (3, 11)

if sys.version_info < (3, 7):
import idna_ssl
4 changes: 2 additions & 2 deletions tests/test_client_request.py
Original file line number Diff line number Diff line change
@@ -19,7 +19,7 @@
Fingerprint,
_merge_ssl_params,
)
from aiohttp.helpers import PY_310
from aiohttp.helpers import PY_311
from aiohttp.test_utils import make_mocked_coro


@@ -276,7 +276,7 @@ def test_host_header_ipv6_with_port(make_request) -> None:


@pytest.mark.xfail(
PY_310,
PY_311,
reason="No idea why ClientRequest() is constructed out of loop but "
"it calls `asyncio.get_event_loop()`",
raises=DeprecationWarning,
4 changes: 2 additions & 2 deletions tests/test_streams.py
Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@
from re_assert import Matches

from aiohttp import streams
from aiohttp.helpers import PY_310
from aiohttp.helpers import PY_311

DATA = b"line1\nline2\nline3\n"

@@ -84,7 +84,7 @@ async def test_create_waiter(self) -> None:
await stream._wait("test")

@pytest.mark.xfail(
PY_310,
PY_311,
reason="No idea why ClientRequest() is constructed out of loop but "
"it calls `asyncio.get_event_loop()`",
raises=DeprecationWarning,
4 changes: 2 additions & 2 deletions tests/test_web_app.py
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@

from aiohttp import log, web
from aiohttp.abc import AbstractAccessLogger, AbstractRouter
from aiohttp.helpers import DEBUG, PY_36, PY_310
from aiohttp.helpers import DEBUG, PY_36, PY_311
from aiohttp.test_utils import make_mocked_coro
from aiohttp.typedefs import Handler

@@ -40,7 +40,7 @@ async def test_set_loop() -> None:


@pytest.mark.xfail(
PY_310,
PY_311,
reason="No idea why _set_loop() is constructed out of loop "
"but it calls `asyncio.get_event_loop()`",
raises=DeprecationWarning,