-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken wsgi.py due to sockname info size #716
Conversation
Addresses issue introduced by cccb9cb
This failed immediately on any request when using aiobottle. Not sure how their codepath differs from existing wsgi tests. |
getsockname may return more then 2 values, e.g. in case of AF_INET6 (host, port, flowinfo, scopeid) Probably we should check the address family and call appropriate code to fill in variables. |
On my OSX box I do get back the four part tuple. I can't say I am familiar with flowinfo or scopeid so it isn't clear how helpful they would be to detect and add them to the 'environ' variable. Given the move to tuple unpacking in the earlier commit, this seemed like the quickest way to get wsgi working again :-) |
I'm with @redixin |
@asvetlov I've made a patch, but it adds one extra call |
|
Fixed by #718 |
Addresses issue introduced by cccb9cb