Client session new args max_line_size and max_field_size

[starflows]

What do these changes do?

Add new arguments max_line_size and max_field_size to ClientSession.

Are there changes in behavior for the user?

No, both arguments are optional and will use the same default values as previously when unset.

Related issue number

#2304
#2988
#3862

Checklist

• I think the code is well written
• Unit tests for the changes exist
• Documentation reflects the changes
• If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • The format is <Name> <Surname>.
  • Please keep alphabetical order, the file is sorted by names.
• Add a new news fragment into the CHANGES folder
  • name it <issue_id>.<type> for example (588.bugfix)
  • if you don't have an issue_id change it to the pr id after creating the pr
  • ensure type is one of the following:
    • .feature: Signifying a new feature.
    • .bugfix: Signifying a bug fix.
    • .doc: Signifying a documentation improvement.
    • .removal: Signifying a deprecation or removal of public API.
    • .misc: A ticket has been closed, but it is not of interest to users.
  • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

[Dreamsorcerer]

I'll leave this one for @asvetlov to evaluate when he comes back. It looks like he has some kind of plan for this: #2304 (comment)

But, #2988 and #3862 appear to be unrelated. They both refer to setting limits in an Application in regards to incoming requests.

[codecov]

Codecov Report

Merging #6744 (644787b) into master (72d3d4b) will decrease coverage by 0.00%.
The diff coverage is 91.42%.

@@            Coverage Diff             @@
##           master    #6744      +/-   ##
==========================================
- Coverage   93.44%   93.43%   -0.01%     
==========================================
  Files         104      104              
  Lines       30627    30697      +70     
  Branches     3076     3086      +10     
==========================================
+ Hits        28620    28683      +63     
- Misses       1838     1844       +6     
- Partials      169      170       +1     

Flag	Coverage Δ
unit	93.36% <91.42%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
aiohttp/client.py	24.51% <0.00%> (-0.33%)	⬇️
aiohttp/client_proto.py	96.71% <ø> (ø)
tests/test_client_functional.py	98.54% <100.00%> (+0.04%)	⬆️
aiohttp/web_protocol.py	89.39% <0.00%> (-0.29%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72d3d4b...644787b. Read the comment docs.

[sumeshmurali]

Is this feature available to use?

[fili]

It looks like this is in the most recent codebase:

aiohttp/aiohttp/client.py

Line 222 in bc37e44

max_line_size: int = 8190,

added using:

ecd9c72

However, trying to use this leads to the following error:

TypeError: ClientSession.__init__() got an unexpected keyword argument 'max_line_size'

And it is also missing from the official documentation:
https://docs.aiohttp.org/en/stable/_modules/aiohttp/client.html#ClientSession
https://docs.aiohttp.org/en/stable/client_reference.html#aiohttp.ClientSession

[Dreamsorcerer]

Ah, didn't notice the duplicate. There are tests in that code, so if you can change one to reproduce the failure and fix the problem, then we can merge it.