Get rid of high connection latency #671
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pass | ||
| if self._keep_alive: | ||
| sock = self.transport.get_extra_info('socket') | ||
| sock.setsockopt(socket.IPPROTO_TCP, |
There was a problem hiding this comment.
Might want to make sure a socket was actually returned and the type of the socket is TCP.
|
Added |
|
@fafhrd91 are you agree with PR? |
|
i still think tcp_nodelay should be on by default. otherwise i am fine |
| # transport is closed | ||
| return | ||
| sock = self.transport.get_extra_info('socket') | ||
| if sock.family not in (socket.AF_INET, socket.AF_INET6): |
There was a problem hiding this comment.
Transports need not have a socket, i.e. get_extra_info('socket') might return a None.
So, should probably do a if sock and sock.family not in (socket.AF_INET, socket.AF_INET6) to be on the safe side.
There was a problem hiding this comment.
@asvetlov I agree with @jashandeep-sohi
|
Close in favor of #680 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #448