-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a bug in creating proxy connection of TCPConnector. #6703
base: master
Are you sure you want to change the base?
Conversation
This fix addresses the issue where an AttributeError is raised when a proxy response is closed du to EOF.
I believe this resolves my issue. Going to try updating my application to use this patch. |
Is there something specific I can do to help? I have a bunch of test cases, but I'm not sure the best way to add them to this patch. |
Test cases would be great. I guess just create a PR to this branch, or a separate PR to aiohttp that includes the commits on this branch. |
I'm not sure how to write a test case that doesn't just exercise the entire request/response cycle with an actual endpoint. I have a "test" here, but it relies on a 3rd party proxy server being up and having that specific configuration: #6239 (comment) Not sure how to extract out the relevant bits and make it a simple unit test. |
I have some additional information here: #6239 (comment) @asvetlov Would it be possible to review this? |
This fix addresses the issue where an AttributeError is raised when a
proxy response is closed due to EOF.
What do these changes do?
Fix the issue #6239.
Are there changes in behavior for the user?
Add ClientProxyClosedError handler.
Related issue number
#6239
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.