Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression test for handling unsupported Upgrade requests (issue #6446) #6451

Merged
merged 2 commits into from
Dec 23, 2021
Merged

Regression test for handling unsupported Upgrade requests (issue #6446) #6451

merged 2 commits into from
Dec 23, 2021

Conversation

pwuertz
Copy link
Contributor

@pwuertz pwuertz commented Dec 23, 2021

What do these changes do?

aiohttp server test for handling client requests with unsupported Upgrade headers (issue #6446).

@pwuertz pwuertz requested a review from asvetlov as a code owner December 23, 2021 09:38
@pwuertz pwuertz marked this pull request as draft December 23, 2021 09:40
@pwuertz pwuertz marked this pull request as ready for review December 23, 2021 09:55
@webknjaz
Copy link
Member

I've added the xfail marker right from the browser so let's see if I didn't make any mistakes.

@webknjaz webknjaz added backport-3.9 bot:chronographer:skip This PR does not need to include a change note labels Dec 23, 2021
@webknjaz webknjaz merged commit a60e8a5 into aio-libs:3.8 Dec 23, 2021
@patchback
Copy link
Contributor

patchback bot commented Dec 23, 2021

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/a60e8a581e3c1987060533a69130ae026cbf6c90/pr-6451

Backported as #6455

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@webknjaz
Copy link
Member

Cherry-picked to 3.9 and master as #6455 and #6456.

webknjaz added a commit that referenced this pull request Dec 23, 2021
…orted Upgrade requests (issue #6446) (#6455)

Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Co-authored-by: Peter Würtz <[email protected]>
@pwuertz pwuertz deleted the pw/test_unsupported_upgrade branch December 23, 2021 18:21
webknjaz added a commit that referenced this pull request Dec 28, 2021
…upported Upgrade requests (issue #6446) (#6456)

Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Co-authored-by: Peter Würtz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants