Terminate properly with signal TERM and INT

[mardiros]

Before this commit, only the QUIT commit do
the cleanup correctly.
Gunicorn base worker call sys.exit(0) on TERM
and INT wich does not close the loop properly.

When running gunicorn in my terminal, terminate it with CTRL+C
or with "pkill gunicorn" should call the close method to properly
exit.

[fafhrd91]

i still think aiohttp is wrong place to put this code. it should be part of gunicorn.

BTW close works with gunicorn master
https://github.com/benoitc/gunicorn/blob/master/gunicorn/workers/base.py#L127

[mardiros]

OK, I am using the 0.18 version, didn't now about this change.

The base class of gunicorn does not have a close method, which I found usefull,
to clean his room (except gevent) so it doesn't really affect them.
But if we can't rely on that close method, it's not usefull at all.

I am happy to known that in the next version of gunicorn, the SIGTERM will be handle properly,
but the SIGQUIT will not call the close method anymore, and the SIGINT is still not working.

[fafhrd91]

what is use case for those signals? you can not relay on SIGTERM, i saw different behavior depends on os. is SIGINT useful in production?

[mardiros]

I currently want to delete amqp queues. I guess I should reconsider that.
To me, SIGINT isn't usesull for production, SIGTERM should be the default signal for terminate a daemon. I don't know if it's true on every unix.

[mardiros]

I am going to override the aiohttp worker now.

https://github.com/mardiros/pyramid_asyncio/blob/master/pyramid_asyncio/worker.py

[fafhrd91]

Just released gunicorn 0.19 has new aiohttp worker "gaiohttp"

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.