-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run test in docker #6132
Run test in docker #6132
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6132 +/- ##
==========================================
- Coverage 93.34% 93.32% -0.02%
==========================================
Files 102 102
Lines 30088 30140 +52
Branches 2689 2696 +7
==========================================
+ Hits 28085 28129 +44
- Misses 1829 1837 +8
Partials 174 174
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Are you committed to supporting this mode for years, adding python 3.11 etc? I personally use pyenv for such things:
|
I'm also not sure I'd want to support yet another test invocation method. Using pyenv is more than enough normally. |
This mode would be only used by people who contribute to aiohttp. If such a person sees that a new python version is missing, they can just add with a couple of lines, isn't it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please merge (and maintain) if you prefer.
It is just a test invocation method, if it will be broken when nobody uses it -- there is no harm.
@asvetlov with backporting to 3.8? |
Up to you. Probably having the PR backported can be handy |
Backport to 3.8: 💚 backport PR created✅ Backport PR branch: Backported as #6154 🤖 @patchback |
* Add make targets for testing with specific version in Docker * Update docs * add CHANGES file * fix spelling (cherry picked from commit 5d1f0ec)
* Add make targets for testing with specific version in Docker * Update docs * add CHANGES file * fix spelling (cherry picked from commit 5d1f0ec) Co-authored-by: Dmitry Erlikh <[email protected]>
What do these changes do?
Add new test targets to the Makefile
Are there changes in behavior for the user?
No
Related issue number
#6131
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.