Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run test in docker #6132

Merged
merged 4 commits into from
Oct 28, 2021
Merged

Run test in docker #6132

merged 4 commits into from
Oct 28, 2021

Conversation

derlih
Copy link
Contributor

@derlih derlih commented Oct 25, 2021

What do these changes do?

Add new test targets to the Makefile

Are there changes in behavior for the user?

No

Related issue number

#6131

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 25, 2021
@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #6132 (98a844d) into master (3dea782) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6132      +/-   ##
==========================================
- Coverage   93.34%   93.32%   -0.02%     
==========================================
  Files         102      102              
  Lines       30088    30140      +52     
  Branches     2689     2696       +7     
==========================================
+ Hits        28085    28129      +44     
- Misses       1829     1837       +8     
  Partials      174      174              
Flag Coverage Δ
unit 93.25% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_worker.py 20.40% <0.00%> (-2.05%) ⬇️
tests/test_connector.py 95.43% <0.00%> (-0.27%) ⬇️
aiohttp/web_app.py 97.33% <0.00%> (ø)
aiohttp/typedefs.py 100.00% <0.00%> (ø)
aiohttp/multipart.py 96.10% <0.00%> (ø)
aiohttp/http_writer.py 97.47% <0.00%> (ø)
aiohttp/web_protocol.py 86.41% <0.00%> (ø)
aiohttp/web_middlewares.py 100.00% <0.00%> (ø)
tests/test_web_functional.py 97.96% <0.00%> (+0.02%) ⬆️
tests/test_cookiejar.py 99.06% <0.00%> (+0.03%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dea782...98a844d. Read the comment docs.

@asvetlov
Copy link
Member

Are you committed to supporting this mode for years, adding python 3.11 etc?

I personally use pyenv for such things:

cd aiohttp
pyenv install 3.10
pyenv virtualenv 3.10 aiohttp-3.10
pyenv local aiohttp-3.10

pyenv local ... call can be used for switching aiohttp environments.
Maybe this approach will work for you?

@webknjaz
Copy link
Member

I'm also not sure I'd want to support yet another test invocation method. Using pyenv is more than enough normally.

@derlih
Copy link
Contributor Author

derlih commented Oct 27, 2021

This mode would be only used by people who contribute to aiohttp. If such a person sees that a new python version is missing, they can just add with a couple of lines, isn't it?

Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please merge (and maintain) if you prefer.

It is just a test invocation method, if it will be broken when nobody uses it -- there is no harm.

@derlih
Copy link
Contributor Author

derlih commented Oct 28, 2021

@asvetlov with backporting to 3.8?

@asvetlov
Copy link
Member

Up to you. Probably having the PR backported can be handy

@derlih derlih merged commit 5d1f0ec into aio-libs:master Oct 28, 2021
@patchback
Copy link
Contributor

patchback bot commented Oct 28, 2021

Backport to 3.8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.8/5d1f0ecae7f7edeb5f6d7ee0e30d72180216a5d1/pr-6132

Backported as #6154

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 28, 2021
* Add make targets for testing with specific version in Docker

* Update docs

* add CHANGES file

* fix spelling

(cherry picked from commit 5d1f0ec)
@derlih derlih deleted the run-test-in-docker branch October 28, 2021 14:57
asvetlov pushed a commit that referenced this pull request Oct 28, 2021
* Add make targets for testing with specific version in Docker

* Update docs

* add CHANGES file

* fix spelling

(cherry picked from commit 5d1f0ec)

Co-authored-by: Dmitry Erlikh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants