Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #5843/728505c1 backport][3.8] Remove external test dependency to http://httpbin.org #6112

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Oct 20, 2021

This is a backport of PR #5843 as merged into master (728505c).

What do these changes do?

Remove external test dependency to http://httpbin.org

Are there changes in behavior for the user?

No

Related issue number

#5840

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #6112 (728505c) into 3.8 (66e281f) will decrease coverage by 4.21%.
The diff coverage is 90.31%.

❗ Current head 728505c differs from pull request most recent head c5f4625. Consider uploading reports for the commit c5f4625 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              3.8    #6112      +/-   ##
==========================================
- Coverage   97.52%   93.31%   -4.22%     
==========================================
  Files          44      102      +58     
  Lines        8865    30066   +21201     
  Branches     1429     2689    +1260     
==========================================
+ Hits         8646    28057   +19411     
- Misses        103     1833    +1730     
- Partials      116      176      +60     
Flag Coverage Δ
unit 93.24% <90.11%> (-4.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/web_fileresponse.py 98.62% <ø> (-1.38%) ⬇️
aiohttp/web_log.py 100.00% <ø> (ø)
aiohttp/web_middlewares.py 100.00% <ø> (ø)
aiohttp/web_protocol.py 86.41% <ø> (-4.20%) ⬇️
aiohttp/web_request.py 95.99% <ø> (-1.57%) ⬇️
aiohttp/web_response.py 98.21% <ø> (-0.06%) ⬇️
aiohttp/web_routedef.py 98.11% <ø> (+0.01%) ⬆️
aiohttp/web_runner.py 92.34% <ø> (-5.29%) ⬇️
aiohttp/web_server.py 94.28% <ø> (-5.72%) ⬇️
aiohttp/web_urldispatcher.py 97.54% <ø> (-0.06%) ⬇️
... and 135 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e31179d...c5f4625. Read the comment docs.

@webknjaz webknjaz enabled auto-merge (squash) October 20, 2021 13:11
@webknjaz webknjaz merged commit 61c4f31 into 3.8 Oct 20, 2021
@webknjaz webknjaz deleted the patchback/backports/3.8/728505c119e6abe96968f13567aaa7e4cbcdbe8f/pr-5843 branch October 20, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants