Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #6107/cd4c700d backport][3.8] Free resp conn @ test_mark_formdata_as_processed #6109

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Oct 20, 2021

This is a backport of PR #6107 as merged into master (cd4c700).

What do these changes do?

This patch attempts to make the tests more stable by explicitly closing the open resouces.

Are there changes in behavior for the user?

No.

Related issue number

I saw this being flaky @ #5930 (before restarting the CI).

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #6109 (cd4c700) into 3.8 (66e281f) will decrease coverage by 4.21%.
The diff coverage is 90.31%.

❗ Current head cd4c700 differs from pull request most recent head 9f8f6fa. Consider uploading reports for the commit 9f8f6fa to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              3.8    #6109      +/-   ##
==========================================
- Coverage   97.52%   93.31%   -4.22%     
==========================================
  Files          44      102      +58     
  Lines        8865    30063   +21198     
  Branches     1429     2690    +1261     
==========================================
+ Hits         8646    28054   +19408     
- Misses        103     1833    +1730     
- Partials      116      176      +60     
Flag Coverage Δ
unit 93.24% <90.11%> (-4.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/web_fileresponse.py 98.62% <ø> (-1.38%) ⬇️
aiohttp/web_log.py 100.00% <ø> (ø)
aiohttp/web_middlewares.py 100.00% <ø> (ø)
aiohttp/web_protocol.py 86.41% <ø> (-4.20%) ⬇️
aiohttp/web_request.py 95.99% <ø> (-1.57%) ⬇️
aiohttp/web_response.py 98.21% <ø> (-0.06%) ⬇️
aiohttp/web_routedef.py 98.11% <ø> (+0.01%) ⬆️
aiohttp/web_runner.py 92.34% <ø> (-5.29%) ⬇️
aiohttp/web_server.py 94.28% <ø> (-5.72%) ⬇️
aiohttp/web_urldispatcher.py 97.54% <ø> (-0.06%) ⬇️
... and 135 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04d9ac4...9f8f6fa. Read the comment docs.

@webknjaz webknjaz enabled auto-merge (squash) October 20, 2021 11:58
@webknjaz webknjaz added the bot:chronographer:skip This PR does not need to include a change note label Oct 20, 2021
@webknjaz webknjaz merged commit 45100df into 3.8 Oct 20, 2021
@webknjaz webknjaz deleted the patchback/backports/3.8/cd4c700d3fc19f15403b5c0de674f39768b61000/pr-6107 branch October 20, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant