[backport][3.8][PR#5809] Integrate autobahn tests with pytest #6074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anesabml
changed the title
5 tasks
* Integrate autobahn tests with pytest * Fix docker compose file paths * Fix typo in CHANGES file * Fix add python-on-whales dependency to .in file instead of .txt * Use pathlib instead of os * Use buildx instead of compose build * Regenerate dev requirements * Rename changes file * Use request fspath instead of hard coded path * Create a sepearte builder when building aiohttp * Use subprocess instead of python-on-whales * Extract failed tests and make assertions on them * Fix lint issues * Fix fixture scope * Add ports to docker-compose files * Add wait-for-it package * Use xfail instead of fail * Use wstest cmd tool instead of the docker image * Fix lint issues * Use assert statement with custom output Co-authored-by: Sviatoslav Sydorenko <[email protected]> * Code cleanup * Use docker instead of docker-compose * Add xfail decorator * Add tmp_path * Remove gitignore * Skip tests only on macOS * Check if docker is available * Regenerate dev.txt Co-authored-by: Sviatoslav Sydorenko <[email protected]> (cherry picked from commit a45c7c5)
|
python-on-whales requires python 3.7 and above. |
|
Oh, so it may need to be reimplemented with pure subprocess calls probably. |
|
@asvetlov I'd rather not merge things into 3.8 that break tests. Especially while I'm working on recovering the broken CI. |
This was referenced Oct 19, 2021
|
Hotfixed by #6103. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Automate running autobahn test suite.
Are there changes in behavior for the user?
No.
Related issue number
#4247
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.