Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a README to the change notes dir #6047

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

webknjaz
Copy link
Member

@webknjaz webknjaz commented Oct 5, 2021

What do these changes do?

$sbj

Are there changes in behavior for the user?

The users can now look up a short guides on adding changelog fragments via the GitHub UI at https://github.com/aio-libs/aiohttp/tree/master/CHANGES.

Related issue number

N/A

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@webknjaz webknjaz added documentation Improvements or additions to documentation bot:chronographer:skip This PR does not need to include a change note backport-3.8 labels Oct 5, 2021
@webknjaz webknjaz requested a review from asvetlov as a code owner October 5, 2021 23:26
@webknjaz webknjaz merged commit 9518bba into aio-libs:master Oct 5, 2021
@webknjaz webknjaz deleted the docs/changelog-readme branch October 5, 2021 23:27
@patchback
Copy link
Contributor

patchback bot commented Oct 5, 2021

Backport to 3.8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.8/9518bba7fdd53a526dd419eb6cf5e426420f0781/pr-6047

Backported as #6048

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant