Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #5928/a341986d backport][3.8] fix: remove deprecated loop argument for asnycio.sleep/gather calls #5929

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Aug 3, 2021

This is a backport of PR #5928 as merged into master (a341986).

What do these changes do?

Remove deprecated loop argument for asnycio.sleep and asyncio.gather calls.

Are there changes in behavior for the user?

No.

Related issue number

Closes #5905 .

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #5929 (a341986) into 3.8 (66e281f) will decrease coverage by 0.77%.
The diff coverage is 96.31%.

❗ Current head a341986 differs from pull request most recent head 7dc0d4f. Consider uploading reports for the commit 7dc0d4f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              3.8    #5929      +/-   ##
==========================================
- Coverage   97.52%   96.75%   -0.78%     
==========================================
  Files          44       44              
  Lines        8865     9852     +987     
  Branches     1429     1591     +162     
==========================================
+ Hits         8646     9532     +886     
- Misses        103      182      +79     
- Partials      116      138      +22     
Flag Coverage Δ
unit 96.65% <96.08%> (-0.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/web_middlewares.py 100.00% <ø> (ø)
aiohttp/web_protocol.py 86.41% <ø> (-4.20%) ⬇️
aiohttp/web_request.py 95.99% <ø> (-1.57%) ⬇️
aiohttp/web_response.py 98.21% <ø> (-0.06%) ⬇️
aiohttp/web_routedef.py 98.11% <ø> (+0.01%) ⬆️
aiohttp/web_runner.py 97.74% <ø> (+0.11%) ⬆️
aiohttp/web_server.py 94.28% <ø> (-5.72%) ⬇️
aiohttp/web_urldispatcher.py 97.83% <ø> (+0.23%) ⬆️
aiohttp/web_ws.py 91.53% <ø> (ø)
aiohttp/worker.py 94.91% <ø> (-1.81%) ⬇️
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7534c0b...7dc0d4f. Read the comment docs.

@Dreamsorcerer Dreamsorcerer merged commit ee68bf4 into 3.8 Aug 3, 2021
@Dreamsorcerer Dreamsorcerer deleted the patchback/backports/3.8/a341986d9e4f577bc879ad4f45a77aaf08ced4f6/pr-5928 branch August 3, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants