Improve English grammar on the deployment doc page #5908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
added
backport-3.8
documentation
webknjaz
approved these changes
Jul 22, 2021
webknjaz
changed the title
Dreamsorcerer
approved these changes
Jul 22, 2021
| @@ -51,10 +51,10 @@ But this way requires more complex configuration. | |||
| Nginx configuration | |||
| -------------------- | |||
|
|
|||
| Here is short extraction about writing Nginx configuration file. | |||
| Here is short example of an Nginx configuration file. | |||
There was a problem hiding this comment.
Suggested change
| Here is short example of an Nginx configuration file. | |
| Here is a short example of an Nginx configuration file. |
There was a problem hiding this comment.
Oh, it got automerged before I saw this. Maybe send a follow up?
Comment on lines
+199
to
+202
| As opposed to deployment with :ref:`bare Nginx | ||
| <aiohttp-deployment-nginx-supervisord>`, this solution does not need to | ||
| manually run several aiohttp processes and use a tool like supervisord | ||
| to monitor them. But nothing is free: running aiohttp |
There was a problem hiding this comment.
Suggested change
| As opposed to deployment with :ref:`bare Nginx | |
| <aiohttp-deployment-nginx-supervisord>`, this solution does not need to | |
| manually run several aiohttp processes and use a tool like supervisord | |
| to monitor them. But nothing is free: running aiohttp | |
| In contrast to deploying with :ref:`bare Nginx | |
| <aiohttp-deployment-nginx-supervisord>`, this solution does not need to | |
| manually run several aiohttp processes. Instead, it uses a tool like supervisord | |
| to monitor them. But nothing is free: running aiohttp |
Codecov Report
@@ Coverage Diff @@
## master #5908 +/- ##
=======================================
Coverage 96.75% 96.75%
=======================================
Files 44 44
Lines 9851 9851
Branches 1591 1591
=======================================
Hits 9531 9531
Misses 182 182
Partials 138 138
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Backport to 3.8: 💚 backport PR created✅ Backport PR branch: Backported as #5910 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jul 22, 2021
(cherry picked from commit c895af4)
5 tasks
webknjaz
pushed a commit
that referenced
this pull request
Jul 22, 2021
(cherry picked from commit c895af4) Co-authored-by: axlrosen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Are there changes in behavior for the user?
Related issue number
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.