Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #5862/7080a8bb backport][3.8] Use MultiLoopChildWatcher in tests where available #5863

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Jul 7, 2021

This is a backport of PR #5862 as merged into master (7080a8b).

What do these changes do?

Python 3.8 adds a new child watcher class that doesn't require running loop in the main thread: https://docs.python.org/3/library/asyncio-policy.html#asyncio.MultiLoopChildWatcher. This PR uses the new watcher if it is available in asyncio module.

It should reduce test flakiness when parallelized with pytest-xdist.

Are there changes in behavior for the user?

No change for end users. Existing tests in test_loop.py covers this change given the current text matrix.

Related issue number

#3450
#2075

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@patchback patchback bot requested review from asvetlov and webknjaz as code owners July 7, 2021 12:42
@webknjaz webknjaz enabled auto-merge (squash) July 7, 2021 12:43
@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #5863 (7080a8b) into 3.8 (8ce3013) will decrease coverage by 0.78%.
The diff coverage is 96.31%.

❗ Current head 7080a8b differs from pull request most recent head 52d8823. Consider uploading reports for the commit 52d8823 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              3.8    #5863      +/-   ##
==========================================
- Coverage   97.53%   96.75%   -0.79%     
==========================================
  Files          44       44              
  Lines        8844     9851    +1007     
  Branches     1424     1591     +167     
==========================================
+ Hits         8626     9531     +905     
- Misses        102      182      +80     
- Partials      116      138      +22     
Flag Coverage Δ
unit 96.65% <96.07%> (-0.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/web_middlewares.py 100.00% <ø> (ø)
aiohttp/web_protocol.py 86.41% <ø> (-4.20%) ⬇️
aiohttp/web_request.py 95.99% <ø> (-1.57%) ⬇️
aiohttp/web_response.py 98.21% <ø> (-0.06%) ⬇️
aiohttp/web_routedef.py 98.11% <ø> (+0.01%) ⬆️
aiohttp/web_runner.py 97.74% <ø> (+0.11%) ⬆️
aiohttp/web_server.py 94.28% <ø> (-5.72%) ⬇️
aiohttp/web_urldispatcher.py 97.83% <ø> (+0.23%) ⬆️
aiohttp/web_ws.py 91.53% <ø> (ø)
aiohttp/worker.py 94.91% <ø> (-1.81%) ⬇️
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 420cc71...52d8823. Read the comment docs.

@webknjaz webknjaz merged commit 68f0262 into 3.8 Jul 7, 2021
@webknjaz webknjaz deleted the patchback/backports/3.8/7080a8bba86db1ea38372183a90d82bfa7d6d8b1/pr-5862 branch July 7, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants