Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect default from docs #5828

Merged
merged 2 commits into from
Jul 18, 2021
Merged

Conversation

Dreamsorcerer
Copy link
Member

Fixes #5827

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jun 22, 2021
@Dreamsorcerer
Copy link
Member Author

Dreamsorcerer commented Jun 22, 2021

Not sure the optional/default actually needs to be said, given that it can be seen in the function signature. But, that's a separate task if someone wants to clean that up.

@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #5828 (f9714e5) into master (38c396b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5828   +/-   ##
=======================================
  Coverage   96.75%   96.75%           
=======================================
  Files          44       44           
  Lines        9849     9849           
  Branches     1591     1591           
=======================================
  Hits         9529     9529           
  Misses        182      182           
  Partials      138      138           
Flag Coverage Δ
unit 96.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38c396b...f9714e5. Read the comment docs.

@AustinScola
Copy link
Contributor

Any reason not to merge this?

@Dreamsorcerer Dreamsorcerer merged commit 60f5727 into master Jul 18, 2021
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-3 branch July 18, 2021 20:27
@patchback
Copy link
Contributor

patchback bot commented Jul 18, 2021

Backport to 3.8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.8/60f57272ab1ac230b2e5a3c8eca9f3ccf9c24252/pr-5828

Backported as #5899

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 18, 2021
webknjaz pushed a commit that referenced this pull request Jul 20, 2021
(cherry picked from commit 60f5727)

Co-authored-by: Sam Bull <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StreamResponse.set_cookie version attribute wrong documentation
2 participants