-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove incorrect default from docs #5828
Conversation
Not sure the optional/default actually needs to be said, given that it can be seen in the function signature. But, that's a separate task if someone wants to clean that up. |
Codecov Report
@@ Coverage Diff @@
## master #5828 +/- ##
=======================================
Coverage 96.75% 96.75%
=======================================
Files 44 44
Lines 9849 9849
Branches 1591 1591
=======================================
Hits 9529 9529
Misses 182 182
Partials 138 138
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Any reason not to merge this? |
Backport to 3.8: 💚 backport PR created✅ Backport PR branch: Backported as #5899 🤖 @patchback |
(cherry picked from commit 60f5727)
(cherry picked from commit 60f5727) Co-authored-by: Sam Bull <[email protected]>
Fixes #5827