Update Makefile pip command #5470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
webknjaz
reviewed
Feb 11, 2021
| @@ -62,7 +62,7 @@ aiohttp/%.c: aiohttp/%.pyx $(call to-hash,$(CYS)) aiohttp/_find_header.c | |||
| cythonize: .install-cython $(PYXS:.pyx=.c) | |||
|
|
|||
| .install-deps: .install-cython $(PYXS:.pyx=.c) $(call to-hash,$(CYS) $(REQS)) | |||
| pip install -r requirements/dev.txt | |||
| @pip install -r requirements/dev.in -c requirements/dev.txt | |||
There was a problem hiding this comment.
It seems like this may need a more intrusive fix: https://github.com/aio-libs/aiohttp/pull/5470/checks?check_run_id=1879584882#step:7:41
webknjaz
reviewed
Feb 11, 2021
| @@ -0,0 +1 @@ | |||
| Fix CI | |||
There was a problem hiding this comment.
Could you add something that'd be useful in the changelog here?
|
I think it's also necessary to do this update in master. |
|
Looks like this is superseeded by #5486. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.