Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #5457 #5464

Merged
merged 2 commits into from
Mar 14, 2021
Merged

Backport #5457 #5464

merged 2 commits into from
Mar 14, 2021

Conversation

Dreamsorcerer
Copy link
Member

@Dreamsorcerer Dreamsorcerer commented Feb 9, 2021

Improve Mypy coverage

I've skipped checking tests on this one as there are a lot of type errors coming through.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Feb 9, 2021
@Dreamsorcerer Dreamsorcerer changed the base branch from master to 3.8 February 9, 2021 20:58
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Feb 9, 2021

This pull request fixes 1 alert when merging ac739e5 into 9a09d1b - view on LGTM.com

fixed alerts:

  • 1 for Wrong number of arguments in a call

@webknjaz
Copy link
Member

webknjaz commented Feb 9, 2021

Looks like this needs patching...

@Dreamsorcerer
Copy link
Member Author

Problem is already in the 3.8 branch (see failed tests on last commit to 3.8).

It looks like the CIMultiDictProxy[str] syntax should work because of this code:
https://github.com/aio-libs/multidict/blob/master/multidict/_abc.py#L7

Is it possible that the functionality is missing from the C version?
https://github.com/aio-libs/multidict/blob/master/multidict/_multidict.c

Or any other ideas @webknjaz?

@Dreamsorcerer
Copy link
Member Author

Problematic annotation was added in: 383016b#diff-197153342549adb4b25580f8b842876841eec42dc48ae12cb72ba2ae4f7ced10R79

I can annotate it another way if needed, but I'd expect it to work if the class supports __getitem__

@webknjaz
Copy link
Member

Dunno, maybe quote it?

@derlih
Copy link
Contributor

derlih commented Feb 10, 2021

I've created the PR #5448 to fix the problem on a CI. But I don't know how to solve the mypy issue there :-(

@Dreamsorcerer Dreamsorcerer merged commit 10f45bb into 3.8 Mar 14, 2021
@Dreamsorcerer Dreamsorcerer deleted the mypy38 branch March 14, 2021 17:56
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Mar 14, 2021

This pull request fixes 1 alert when merging 9cbcb41 into 30f90c5 - view on LGTM.com

fixed alerts:

  • 1 for Wrong number of arguments in a call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants