-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport #5457 #5464
Backport #5457 #5464
Conversation
This pull request fixes 1 alert when merging ac739e5 into 9a09d1b - view on LGTM.com fixed alerts:
|
Looks like this needs patching... |
Problem is already in the 3.8 branch (see failed tests on last commit to 3.8). It looks like the Is it possible that the functionality is missing from the C version? Or any other ideas @webknjaz? |
Problematic annotation was added in: 383016b#diff-197153342549adb4b25580f8b842876841eec42dc48ae12cb72ba2ae4f7ced10R79 I can annotate it another way if needed, but I'd expect it to work if the class supports |
Dunno, maybe quote it? |
I've created the PR #5448 to fix the problem on a CI. But I don't know how to solve the mypy issue there :-( |
This pull request fixes 1 alert when merging 9cbcb41 into 30f90c5 - view on LGTM.com fixed alerts:
|
Improve Mypy coverage
I've skipped checking tests on this one as there are a lot of type errors coming through.